Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tender ctis warning and ensure not after 2022-06-25 #1173

Merged
merged 2 commits into from
Apr 14, 2022
Merged

tender ctis warning and ensure not after 2022-06-25 #1173

merged 2 commits into from
Apr 14, 2022

Conversation

sgratzl
Copy link
Member

@sgratzl sgratzl commented Apr 14, 2022

closes #1172

Prerequisites:

  • Unless it is a hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

Summary

the text id here: https://docs.google.com/document/d/1J36nedP6eufeRE3TbyT_BK-ofE5d18kLif2UmORkYDU/edit#

please edit as needed, then I can update the document. It looks like this:

image

after June 25 the notice text will be shown.

@sgratzl sgratzl added the enhancement New feature or request label Apr 14, 2022
@sgratzl sgratzl self-assigned this Apr 14, 2022
@netlify
Copy link

netlify bot commented Apr 14, 2022 •
edited
Loading

✅ Preview link ready!

Name Link
🔨 Latest commit 4ab4d67
🔍 Latest deploy log https://app.netlify.com/sites/cmu-delphi-covidcast/deploys/62584cae9629f50009d2d545
😎 Deploy Preview https://deploy-preview-1173--cmu-delphi-covidcast.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@capnrefsmmat
Copy link
Contributor

Thanks, this looks good. I made a few edits to the text in the Google Doc, and I think this will be good to deploy afterward.

@sgratzl
Copy link
Member Author

sgratzl commented Apr 14, 2022

updated the text

krivard
krivard approved these changes Apr 14, 2022
View reviewed changes
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sgratzl sgratzl merged commit fe5c24d into dev Apr 14, 2022
@sgratzl sgratzl deleted the sgratzl/ctis_warning branch April 14, 2022 21:08
@krivard krivard mentioned this pull request May 23, 2022
Merged
@capnrefsmmat capnrefsmmat mentioned this pull request Jul 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@capnrefsmmat capnrefsmmat capnrefsmmat approved these changes

@krivard krivard krivard approved these changes

Assignees

@sgratzl sgratzl

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prepare CTIS dashboard for survey end
3 participants
@sgratzl @capnrefsmmat @krivard