Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Cornercase in rounding #1176

Merged
merged 1 commit into from
May 20, 2022
Merged

fix Cornercase in rounding #1176

merged 1 commit into from
May 20, 2022

Conversation

sgratzl
Copy link
Member

@sgratzl sgratzl commented May 18, 2022

closes #1175

Prerequisites:

  • Unless it is a hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

Summary

image

@sgratzl sgratzl added the bug Something isn't working label May 18, 2022
@sgratzl sgratzl requested a review from krivard May 18, 2022 20:37
@sgratzl sgratzl self-assigned this May 18, 2022
@netlify
Copy link

netlify bot commented May 18, 2022

✅ Preview link ready!

Name Link
🔨 Latest commit e16c030
🔍 Latest deploy log https://app.netlify.com/sites/cmu-delphi-covidcast/deploys/628558f8fa73ea0009252278
😎 Deploy Preview https://deploy-preview-1176--cmu-delphi-covidcast.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

krivard
krivard approved these changes May 19, 2022
View reviewed changes
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice solution

@sgratzl sgratzl merged commit cce552e into dev May 20, 2022
@sgratzl sgratzl deleted the sgratzl/fix_formatting branch May 20, 2022 06:19
@krivard krivard mentioned this pull request May 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krivard krivard krivard approved these changes

Assignees

@sgratzl sgratzl

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hospitalization topline number appears to be wrong
2 participants
@sgratzl @krivard