Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change summary charts to hospital admissions #1196

Merged
merged 2 commits into from
Dec 9, 2022

Conversation

krivard
Copy link
Contributor

@krivard krivard commented Dec 7, 2022

closes #1195

Prerequisites:

  • Unless it is a hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

Summary

  • Swaps out cases sensor for hospital admissions sensor on summary page in map and plot sections.
  • Also renames overview panel from "cases overview" since we are likely to eventually phase out cases.

@netlify
Copy link

netlify bot commented Dec 7, 2022

Preview link ready!

Name Link
🔨 Latest commit 09961bc
🔍 Latest deploy log https://app.netlify.com/sites/cmu-delphi-covidcast/deploys/6390b711f2195100086574f8
😎 Deploy Preview https://deploy-preview-1196--cmu-delphi-covidcast.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@krivard
Copy link
Contributor Author

krivard commented Dec 7, 2022

Tagging @nolangormley for a code review (you don't need much svelte for this, it's a minor change but extra eyes are always good) and @christymelucci for a visual review

@christymelucci
Copy link
Collaborator

christymelucci commented Dec 8, 2022

I see that the intended changes have been successfully completed, but also see three minor unexpected items that I will note here just in case they are of interest. To review these items, see text comments on the attached screenshot.

2022-12-08-v2.pdf

@krivard
Copy link
Contributor Author

krivard commented Dec 9, 2022

Great attention to detail! However, these all appear on the currently live version as well, so were not introduced in this PR. I've made new bugs for them in most cases:

Copy link

@nolangormley nolangormley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Found a bug with firefox when you open the inspect window. This bug was not introduced in this PR though so it's not fully relevant.

@krivard krivard merged commit f42aa22 into dev Dec 9, 2022
@krivard krivard deleted the krivard/default-chart-hospn branch December 9, 2022 17:51
@krivard krivard mentioned this pull request Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add flu signals to dashboard
3 participants