Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade uikit to 3.16.13 #1213

Merged
merged 3 commits into from
Apr 26, 2023
Merged

Upgrade uikit to 3.16.13 #1213

merged 3 commits into from
Apr 26, 2023

Conversation

krivard
Copy link
Contributor

@krivard krivard commented Mar 31, 2023

Prep for cmu-delphi/www-main#781

Prerequisites:

  • Unless it is a hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

Summary

UIKit 3.16.13 breaks layout for the location dropdowns. This PR is a fix.

Status:

  • covidcast explore a location
  • covidcast explore an indicator
  • ctis dashboard
  • dashboard builder
  • indicator status

* location dropdown no longer affects flow of nav bar
* clear and location icons display at correct line
* works on covidcast location, covidcast indicator, and ctis pages
* does not work on dashboard builder yet
@netlify
Copy link

netlify bot commented Mar 31, 2023

Preview link ready!

Name Link
🔨 Latest commit 48501a9
🔍 Latest deploy log https://app.netlify.com/sites/cmu-delphi-covidcast/deploys/642753c4d8422e000868fc9c
😎 Deploy Preview https://deploy-preview-1213--cmu-delphi-covidcast.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@krivard krivard changed the title Krivard/uikit Upgrade uikit to 3.16.13 Apr 4, 2023
@krivard krivard marked this pull request as ready for review April 26, 2023 16:36
@krivard krivard merged commit f853744 into dev Apr 26, 2023
@krivard krivard deleted the krivard/uikit branch April 26, 2023 16:37
@melange396 melange396 mentioned this pull request May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant