Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync descriptions and questions to delphi-epidata #1216

Merged
merged 4 commits into from
Apr 28, 2023

Conversation

rzats
Copy link
Contributor

@rzats rzats commented Apr 27, 2023

Prerequisites:

  • Unless it is a hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

Summary

As part of the "Create Release" action in the www-covidcast repo, creates a PR in the delphi-epidata repo that updates (copies) two text files from www-covidcast.

Tested out in my fork of this repo. A link to a successful run can be found here, and the PR it created it is cmu-delphi/delphi-epidata#1154.

PREREQUISITE: Add a secret to this repo called CMU_DELPHI_DEPLOY_MACHINE_PAT, which is a personal access token with access to both this repo and delphi-epidata.

@netlify
Copy link

netlify bot commented Apr 27, 2023

Preview link ready!

Name Link
🔨 Latest commit f2bf482
🔍 Latest deploy log https://app.netlify.com/sites/cmu-delphi-covidcast/deploys/644be12b15a2330008386e4b
😎 Deploy Preview https://deploy-preview-1216--cmu-delphi-covidcast.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@melange396 melange396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice! have you tried this when the files already exist in the target repo? i presume cp does not complain about overwriting them. also, if there is no change to the files, does the "create PR" step exit with a graceful no-op?

.github/workflows/create_release.yml Outdated Show resolved Hide resolved
.github/workflows/create_release.yml Outdated Show resolved Hide resolved
rzats and others added 2 commits April 27, 2023 20:03
Co-authored-by: melange396 <george.haff@gmail.com>
Co-authored-by: melange396 <george.haff@gmail.com>
@rzats
Copy link
Contributor Author

rzats commented Apr 27, 2023

@melange396 I've applied the changes!

i presume cp does not complain about overwriting them

indeed! it just overwrites silently

also, if there is no change to the files, does the "create PR" step exit with a graceful no-op?

Yep, that action doesn't create a pull request with +0/-0 if there are no changes

@rzats rzats requested a review from melange396 April 27, 2023 17:11
Copy link
Contributor

@melange396 melange396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@korlaxxalrok korlaxxalrok requested review from korlaxxalrok and removed request for korlaxxalrok April 28, 2023 15:16
@korlaxxalrok korlaxxalrok merged commit 2b2fb48 into cmu-delphi:dev Apr 28, 2023
4 checks passed
@melange396 melange396 mentioned this pull request May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants