Update COVIDcast export integration

[rzats]

Followup to #1244.

Prerequisites:

• Unless it is a hotfix it should be merged against the dev branch
• Branch is up-to-date with the branch to be merged with, i.e. dev
• Build is successful
• Code is cleaned up and formatted

Summary

Fixes some pending issues from #1244:

• Makes sure geo_value works for lowercase state names.
• Adds code comment about timezone conversions, especially explaining the weird double negative.
• Makes the indicator dashboard correctly integrate with the export dashboard, turning its parameters (sensor, region and date) into URL parameters. Link for testing TBD.

Testing example:

https://deploy-preview-1252--cmu-delphi-covidcast.netlify.app/indicator/?sensor=hhs-confirmed_admissions_influenza_1d_prop_7dav&region=AK&date=20240426

[netlify]

✅ Preview link ready!

Name	Link
🔨 Latest commit	c73079c
🔍 Latest deploy log	https://app.netlify.com/sites/cmu-delphi-covidcast/deploys/667dafb04ecd530008c675f2
😎 Deploy Preview	https://deploy-preview-1252--cmu-delphi-covidcast.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[rzats]

@melange396 @dshemetov this is ready for review! One quick note re: #1244 (comment)

would it remove the need for geoURLSet if we put this outside of the $: {} block?

I doublechecked and that declaration relies on another variable within the $ block, so unfortunately no.

[dshemetov]

Hm, your testing example

https://deploy-preview-1252--cmu-delphi-covidcast.netlify.app/export/?sensor=hhs-confirmed_admissions_influenza_1d_prop_7dav&region=AK&date=20240426

doesn't seem to be doing the right thing? The URL gets reduced down to

https://deploy-preview-1252--cmu-delphi-covidcast.netlify.app/export/?sensor=hhs-confirmed_admissions_influenza_1d_prop_7dav

which doesn't end up selecting any parameters. Is this just an issue on my machine? I'm on Firefox. I'm expecting the URL to be reduced down to

https://deploy-preview-1252--cmu-delphi-covidcast.netlify.app/export/?data_source=hhs&signal=confirmed_admissions_influenza_1d_prop_7dav&region=AK&date=20240426

does that happen your machine?

[rzats]

@dshemetov to clarify, my testing example is:

https://deploy-preview-1252--cmu-delphi-covidcast.netlify.app/indicator/?sensor=hhs-confirmed_admissions_influenza_1d_prop_7dav&region=AK&date=20240426

(note the /indicator URL rather than /export)

Once on that page, click the "Export Data" link on the "about" panel and it should redirect you to the correct /export URL. (That said, if something on the website is redirecting you to the incorrect /export URL, please let me know!)

[dshemetov]

Hm, so when I follow your instructions (on Firefox and Chrome), the URL

https://deploy-preview-1252--cmu-delphi-covidcast.netlify.app/indicator/?sensor=hhs-confirmed_admissions_influenza_1d_prop_7dav&region=AK&date=20240426

and then click Export Data, it turns into

https://deploy-preview-1252--cmu-delphi-covidcast.netlify.app/export/?sensor=hhs-confirmed_admissions_influenza_1d_prop_7dav

Does that not happen for you?

[dshemetov]

Still having some issues getting this to work.

[dshemetov]

Is the path here off? It was ../.. before? Same for the two imports below.

[melange396]

it may not be worth adding all this complexity; the signal documentation app now has its own date/location chooser which enables it to use the /covidcast/csv endpoint directly (see cmu-delphi/signal_documentation#104), and this functionality in the covidcast export page is no longer needed.

[rzats]

@melange396 that makes sense for the signal documentation app! However we'd like to link to the export page from other parts of the website as well. e.g., https://delphi.cmu.edu/covidcast/indicator/ has "Export Data" links for each indicator:

which are intended to do what this PR and #1244 implement - redirect the user to the covidcast export page, where the form is pre-filled according to the currently selected sensor. But currently these links simply discard the ?sensor parameter (try visiting https://delphi.cmu.edu/covidcast/export?sensor=google-symptoms-s05_smoothed_search for an example).

[dshemetov]

@rzats Hm, this functionality isn't working for me (same example as in my comment above, same example as in your top comment here; I tried Chrome, Firefox, Safari). Is it working for you?

[dshemetov]

Alright, all the buttons are working for me now. I tried a number of different sources and geos and it looks good to me. Thanks for all the iterations, Rostyslav 👍