Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: incomplete imputation in detail view #535

Merged
merged 4 commits into from Oct 14, 2020
Merged

fix: incomplete imputation in detail view #535

merged 4 commits into from Oct 14, 2020

Conversation

sgratzl
Copy link
Member

@sgratzl sgratzl commented Oct 5, 2020

closes #534

Prerequisites:

  • Unless it is a hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

Summary

image

@sgratzl sgratzl added this to In Review/Testing in COVIDCast Ongoing Development Oct 5, 2020
@netlify
Copy link

netlify bot commented Oct 13, 2020

Preview link ready!

Built with commit 9b621aa

https://deploy-preview-535--cmu-delphi-covidcast.netlify.app

@sgratzl sgratzl linked an issue Oct 13, 2020 that may be closed by this pull request
signal rendered as zero in big chart but as missing in small multiple #534
Closed
dlaliberte
dlaliberte approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@dlaliberte dlaliberte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it fixes the problem.

@tildechris tildechris merged commit cbffbb1 into dev Oct 14, 2020
COVIDCast Ongoing Development automation moved this from In Review/Testing to Done Oct 14, 2020
@tildechris tildechris deleted the sgratzl/bugfix_missing branch October 14, 2020 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlaliberte dlaliberte dlaliberte approved these changes

@tildechris tildechris Awaiting requested review from tildechris

Assignees

@tildechris tildechris

Labels
None yet
Projects
No open projects
COVIDCast Ongoing Development
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

signal rendered as zero in big chart but as missing in small multiple
3 participants
@sgratzl @dlaliberte @tildechris