Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

additional export infos #629

Merged
merged 8 commits into from Nov 25, 2020
Merged

additional export infos #629

merged 8 commits into from Nov 25, 2020

Conversation

sgratzl
Copy link
Member

@sgratzl sgratzl commented Nov 12, 2020

closes #599

Prerequisites:

  • Unless it is a hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

Summary

extends the exports page, by

  • showing the common help icon next to signals
  • add more links to meaning of data structures
  • add a CSV version with links and hints how to use it with wget

image

@capnrefsmmat what do you think?

(note the changehc signal is just part of my system)

@sgratzl sgratzl self-assigned this Nov 12, 2020
@netlify
Copy link

netlify bot commented Nov 12, 2020

Preview link ready!

Built with commit 9596930

https://deploy-preview-629--cmu-delphi-covidcast.netlify.app

@capnrefsmmat
Copy link
Contributor

Question: Most of our data is released under the terms of the CC-BY license, but some data sources have other terms. Is there a good way for us to embed licensing information and show it on the download page?

I think the "We would be happy for you..." would just need to be conditional on source, so by default it would say "under the terms of the Creative Commons Attribution license", but for other sources it would say the data is provided by [some source] under [some terms].

@sgratzl
Copy link
Member Author

sgratzl commented Nov 17, 2020

I think the "We would be happy for you..." would just need to be conditional on source, so by default it would say "under the terms of the Creative Commons Attribution license", but for other sources it would say the data is provided by [some source] under [some terms].

what about adding a field to the signal description at https://docs.google.com/document/d/1RLy4O-gtACVjLEVD_vxyPqvp9nWVhqEjoWAKi68RKpg/edit#heading=h.oxebzdy7nl8w which can cover those cases?

see also new suggestions in the google doc

@sgratzl
Copy link
Member Author

sgratzl commented Nov 25, 2020

current state:

  • renamed Data source to "Cases and Deaths"
  • add see also with the links from the description
  • incorporate the credit section from the description field in google doc

image

@tildechris
Copy link
Contributor

Do we expect the wget command to work on the existing version?

wget --content-disposition "https://delphi.cmu.edu/csv?signal=doctor-visits:smoothed_adj_cli&start_day=2020-10-24&end_day=2020-11-24&geo_type=county"

Failed for me with a 502: Bad Gateway.

@sgratzl
Copy link
Member Author

sgratzl commented Nov 25, 2020

Failed for me with a 502: Bad Gateway.

seems more like the server is down

Copy link
Contributor

@tildechris tildechris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Sam.

@tildechris
Copy link
Contributor

Merging in order to make release branch

@tildechris tildechris merged commit 764f20b into dev Nov 25, 2020
@tildechris tildechris deleted the sgratzl/export_infos branch November 25, 2020 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants