New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce layout flicker on Region Details #652
Conversation
Preview link ready! Built with commit 6220832 https://deploy-preview-652--cmu-delphi-covidcast.netlify.app |
There are a couple edge cases that still need a bit of work. e.g. With one column, the table expands too much if the window is wide. |
Flickering tooltip is different from flickering layout of the charts and tables. The tooltip flickers less than it used to, but there are still some more cases when it is drawn off the window that it flickers.
This change is about the flickering layout. It's pretty rock solid now. I wouldn't wait. |
Ah, as per our discussion, you fixed the flicker with the chart area, and the tooltip flicker is a different issue. Let's move forward with the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks Daniel, you can merge.
closes #637
Prerequisites:
dev
branchdev
Summary
Change layout and formatting to keep legend columns stable as user hovers over various values.
Also fix legend color for first signal to match gray color in chart.