Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added initial round of test cases... #66

Merged
merged 5 commits into from Nov 20, 2015
Merged

Conversation

amurrayw
Copy link
Contributor

Hi Joe,

Fixed up my basic test cases. I'll likely add more (and will also clean up the test file), but this will help us flag anything that induces major breakage.

Best,

Alexander

jdramsey added a commit that referenced this pull request Nov 20, 2015
Added initial round of test cases...
@jdramsey jdramsey merged commit ce49693 into cmu-phil:master Nov 20, 2015
@jdramsey
Copy link
Collaborator

Test 2 and 3 are failing for me; I disabled them so all the unit tests would pass. Are they passing for you?

@amurrayw
Copy link
Contributor Author

They were when I made the pull request. I'll double check though.

  • Alexander

On Fri, Nov 20, 2015 at 3:28 PM, jdramsey notifications@github.com wrote:

Test 2 and 3 are failing for me; I disabled them so all the unit tests
would pass. Are they passing for you?


Reply to this email directly or view it on GitHub
#66 (comment).

Alexander Murray-Watters
Logic, Computation, and Methodology M.S.
Carnegie Mellon University
amurrayw@cmu.edu

@amurrayw
Copy link
Contributor Author

I've fixed test case 2, I'll fix test case 3 as well (something silly
happened when I moved the old test file over to the git repo).

On Fri, Nov 20, 2015 at 3:29 PM, Alexander Murray-Watters <
ajgmw5565@gmail.com> wrote:

They were when I made the pull request. I'll double check though.

  • Alexander

On Fri, Nov 20, 2015 at 3:28 PM, jdramsey notifications@github.com
wrote:

Test 2 and 3 are failing for me; I disabled them so all the unit tests
would pass. Are they passing for you?


Reply to this email directly or view it on GitHub
#66 (comment).

Alexander Murray-Watters
Logic, Computation, and Methodology M.S.
Carnegie Mellon University
amurrayw@cmu.edu

Alexander Murray-Watters
Logic, Computation, and Methodology M.S.
Carnegie Mellon University
amurrayw@cmu.edu

@amurrayw
Copy link
Contributor Author

Fixed in latest pull request.

On Friday, November 20, 2015, Alexander Murray-Watters ajgmw5565@gmail.com
wrote:

I've fixed test case 2, I'll fix test case 3 as well (something silly
happened when I moved the old test file over to the git repo).

On Fri, Nov 20, 2015 at 3:29 PM, Alexander Murray-Watters <
ajgmw5565@gmail.com javascript:_e(%7B%7D,'cvml','ajgmw5565@gmail.com');>
wrote:

They were when I made the pull request. I'll double check though.

  • Alexander

On Fri, Nov 20, 2015 at 3:28 PM, jdramsey <notifications@github.com
javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

Test 2 and 3 are failing for me; I disabled them so all the unit tests
would pass. Are they passing for you?


Reply to this email directly or view it on GitHub
#66 (comment).

Alexander Murray-Watters
Logic, Computation, and Methodology M.S.
Carnegie Mellon University
amurrayw@cmu.edu javascript:_e(%7B%7D,'cvml','amurrayw@cmu.edu');

Alexander Murray-Watters
Logic, Computation, and Methodology M.S.
Carnegie Mellon University
amurrayw@cmu.edu javascript:_e(%7B%7D,'cvml','amurrayw@cmu.edu');

Alexander Murray-Watters
Logic, Computation, and Methodology M.S.
Carnegie Mellon University
amurrayw@cmu.edu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants