Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: default Vega-Lite-based renderer (#342) #438
feat: default Vega-Lite-based renderer (#342) #438
Changes from 10 commits
3de1ba4
932ed30
50e0dfd
535dcb4
6f33063
01e2eba
43644e6
182c8d1
705a68f
68e65e8
f15dda8
2630f61
9f8162d
01ec390
fc68609
2c9cac7
1da11b6
d7a789e
2831d86
56926dc
d961948
1f1de2c
d8a7089
e098422
53d47ce
88ef8ef
7727e25
e59d9a8
ebe3d78
ea26fe7
cc802f6
5c53486
bcaa8fe
0925055
1d972e0
8910c7a
94dc9e9
ea7e7a7
bb7547a
dfada10
6a36bad
76795ec
d6f06a8
8b96f55
320cf54
aac04b9
39e400a
4e380ec
bd7ca3b
25659fe
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this logic is correct. We should look at the scale type instead. The data type could be number but the scale could be categorical or continuous.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Meeting notes:
Scale type provides a cleaner mapping, as it makes it possible to differentiate between different number types such as numerical, ordinal, and categorical.