Allow custom nodelay #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently ibrowse defined the nodelay socket option to true, not allowing the caller to supply its own value, which would also make the sndbuf option useless if the caller supplied it as well. When sending large bodies, setting nodelay to false with a custom sndbuf can improve network throughput very significantly. For e.g., custom tests reduced an upload from 16 minutes to about 12 minutes.
|
Thanks. Fixed. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Chandru,
Please see the commit message:
fdmanana@901eb69
When uploading large bodies, specially with a streaming function, this allows the caller to improve network throughput.
I aslo removed the to_integer/1 function since it was useless in the do_connect/4 function and not used anywhere else (compiler warning).
thanks