Ipv6 support

[fdmanana]

Hi Chandru,

Haven't tested it yet, but I think this is a useful addition.

Have you already tried using ibrowse against an IPv6-only host? Sometimes the user may be clueless about whether the remote host is IPv6-only or not, so detecting that and adding the int6 parameter if necessary seems reasonable to do.

regards

[cmullaparthi]

Looks good Filipe, I'll try testing it and include it after that. I'll
probably also look into how the built in HTTP client deals with IPv6.

cheers
Chandru

On 16 March 2011 18:35, fdmanana <
reply@reply.github.com>wrote:

Hi Chandru,

Haven't tested it yet, but I think this is a useful addition.

Have you already tried using ibrowse against an IPv6-only host? Sometimes
the user may be clueless about whether the remote host is IPv6-only or not,
so detecting that and adding the int6 parameter if necessary seems
reasonable to do.

regards

Reply to this email directly or view it on GitHub:
#34

[fdmanana]

One last finding, is that ibrowse_lib:parse_url/1 doesn't parse IPv6 address - once it finds ":" it assumes that what follows is a port number.
I haven't had the time yet to change it, but in the meanwhile I found some code that does the parsing of IPv6 addresses:

http://stuff.mit.edu/afs/athena/software/erlang_vR12B-3/lib/erlang/lib/kernel-2.12.3/src/inet_parse.erl

It's just a matter of integrating it :)

[fdmanana]

Ah and here is an interesting discussion about URL parsing with IPv6 address literals and port numbers:

http://lists.w3.org/Archives/Public/www-talk/1996JulAug/0088.html

Will try it when I get the time, possibly not anytime soon.

[cmullaparthi]

Thanks for digging all this out! I'll see if I can do it myself, otherwise I
will graciously accept a patch :)

cheers
Chandru

On 30 March 2011 12:25, fdmanana <
reply@reply.github.com>wrote:

Ah and here is an interesting discussion about URL parsing with IPv6
address literals and port numbers:

http://lists.w3.org/Archives/Public/www-talk/1996JulAug/0088.html

Will try it when I get the time, possibly not anytime soon.

Reply to this email directly or view it on GitHub:
#34 (comment)

[fdmanana]

Hi again Chandru,

I just added support for IPv6 literals in hostnames when using ibrowse_lib:parse_url/1

Commits

fdmanana@3367f00

and

fdmanana@f5640f5

Note that I added a new eunit test for ibrowse_lib:parse_url/1, somehow it feels more natural (and standard) than adding it to ibrowse_test.erl.

Let me know what you think.

cheers