Switch back to Cython and use scikit-build for Python module #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the SoundSwallower Cython code as a starting point
dhdaines
changed the title
lenzo-ka
approved these changes
Jul 22, 2022
| int ps_reinit_feat(ps_decoder_t *ps, cmd_ln_t *config) | ||
| logmath_t *ps_get_logmath(ps_decoder_t *ps) | ||
| int ps_start_stream(ps_decoder_t *ps) | ||
| int ps_get_in_speech(ps_decoder_t *ps) |
There was a problem hiding this comment.
Can you expose get_in_speech as well? That would let you do some nice things like keep a mic open but discard the. audio up to x msec before speech starts
There was a problem hiding this comment.
ahh, funny you mention this, because I had removed get_in_speech as the internal VAD, which it used, was buggy and also not a very good VAD. do you have code that uses it already? I am trying to figure out what exactly the use case is for it and whether it can be supported or not...
There was a problem hiding this comment.
No -- and actually we can just check if there are word in the hyp, so I wouldn't worry about it
dhdaines
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cython makes somewhat larger binaries, but it has the following advantages:
The SWIG code is unmaintained since a long time, I don't have time to support it, and in any case the Ruby bindings (https://github.com/watsonbox/pocketsphinx-ruby) don't even use it.