Bring your own bucket #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnonino
approved these changes
Jan 9, 2023
bion
pushed a commit
to civiform/cloud-deploy-infra
that referenced
this pull request
Jan 9, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [cn-terraform/ecs-fargate-service/aws](https://registry.terraform.io/modules/cn-terraform/ecs-fargate-service/aws) ([source](https://togithub.com/cn-terraform/terraform-aws-ecs-fargate-service)) | module | patch | `2.0.36` -> `2.0.38` | --- ### Release Notes <details> <summary>cn-terraform/terraform-aws-ecs-fargate-service</summary> ### [`v2.0.38`](https://togithub.com/cn-terraform/terraform-aws-ecs-fargate-service/releases/tag/2.0.38) [Compare Source](https://togithub.com/cn-terraform/terraform-aws-ecs-fargate-service/compare/2.0.37...2.0.38) #### What's Changed - Bring your own bucket by [@​tvaughan77](https://togithub.com/tvaughan77) in [cn-terraform/terraform-aws-ecs-fargate-service#65 #### New Contributors - [@​tvaughan77](https://togithub.com/tvaughan77) made their first contribution in [cn-terraform/terraform-aws-ecs-fargate-service#65 **Full Changelog**: cn-terraform/terraform-aws-ecs-fargate-service@2.0.37...2.0.38 ### [`v2.0.37`](https://togithub.com/cn-terraform/terraform-aws-ecs-fargate-service/releases/tag/2.0.37) [Compare Source](https://togithub.com/cn-terraform/terraform-aws-ecs-fargate-service/compare/2.0.36...2.0.37) #### What's Changed - issues [#​59](https://togithub.com/cn-terraform/terraform-aws-ecs-fargate-service/issues/59) Add an option for enabling deployment_circuit_breaker by [@​akaiypova-jetty](https://togithub.com/akaiypova-jetty) in [cn-terraform/terraform-aws-ecs-fargate-service#61 #### New Contributors - [@​akaiypova-jetty](https://togithub.com/akaiypova-jetty) made their first contribution in [cn-terraform/terraform-aws-ecs-fargate-service#61 **Full Changelog**: cn-terraform/terraform-aws-ecs-fargate-service@2.0.36...2.0.37 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/civiform/cloud-deploy-infra). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC41NC4yIiwidXBkYXRlZEluVmVyIjoiMzQuOTUuMCJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the use of the
cn-terraform/ecs-alb/awssister module from v1.0.27 -> v1.0.28 which enables the "bring your own log bucket" capabilities to the ALB module.With this PR, there's no functional changes to this ECS module, it just passes through a new
log_bucket_idvariable to the ecs-alb module that will dictate whether or not the new ECS service will have a brand new S3 bucket created for it for the purpose of LB logging, or if the logging will be setup to use a previously existing bucket.