Fix linter settings and errors #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolynvs
approved these changes
May 18, 2020
|
|
||
| linters-settings: | ||
| goimports: | ||
| local-prefixes: github.com/radu-matei/cnab-go | ||
| local-prefixes: github.com/cnabio/cnab-go |
vdice
approved these changes
May 18, 2020
|
I'm confused as to why the az pipeline is failing on this change 🤔 edit: ah, I think maybe we're encountering a new az vm agent perhaps w/o go1.13 compat? A run off of master failed in the same manner: https://dev.azure.com/deislabs/cnab-go/_build/results?buildId=5945&view=logs&j=12f1170f-54f2-53f3-20dd-22fc7dff55f9&t=5caf77c8-9b10-50ef-b5c7-ca89c63e1c86 (so, nothing in this PR should be causing it to fail, as expected.) edit no. 2: Carolyn to the rescue! CI fix in #209 |
Signed-off-by: Radu M <root@radu.sh>
|
Rebased, but for some reason the build is not triggering.. Edit: it just took some time before it got triggered, seems to be working now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
goimportssettings in the linter options were wrong, meaninggoimportswas not running properly.This PR fixes that, as well as the linter errors.