Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cnab-go, Go, docker, containerd #119

Merged
merged 2 commits into from
Mar 18, 2022
Merged

Conversation

carolynvs
Copy link
Collaborator

@carolynvs carolynvs commented Mar 14, 2022

Update to the most recently patched versions of cnab-go Go, docker, containerd, and image-spec. Also fixes the circleci build which was failing due to being on an old version of Go.

Closes #114
Closes #116
Closes #117

I will rebase and move out of draft when cnabio/cnab-go#281 is merged.

@carolynvs carolynvs marked this pull request as ready for review March 14, 2022 19:49
@carolynvs carolynvs force-pushed the bump-deps branch 6 times, most recently from a03dded to e5bcac0 Compare March 14, 2022 21:08
@carolynvs carolynvs marked this pull request as draft March 14, 2022 22:20
* Use a supported build image
* Use a patched version of Go
* Use go install instead of go get to install tools
* Use the go proxy, direct was an impossible performance problem on
newer veresions of Go

Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Update to the most recently patched versions of cnab-go,
docker, containerd, and image-spec.

Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Copy link
Member

@radu-matei radu-matei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Selecting the compatible versions for all the things here must have been a pain, thank you so much!

LGTM

@carolynvs carolynvs merged commit 757f6fe into cnabio:main Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants