Skip to content
This repository has been archived by the owner on May 3, 2022. It is now read-only.

Commit

Permalink
Rename k8s driver parm from KUBE_CONFIG to KUBECONFIG
Browse files Browse the repository at this point in the history
Implement this by bumping cnab-go. Also picks up other fixes.

KUBECONFIG is the de facto standard environment variable for kubectl etc.

Without this change when the user omits KUBE_CONFIG, the default kube config
will be used, which may well point to a valid cluster, though this will
effectively be the wrong cluster when the user has set $KUBECONFIG.

This is a particular issue when kind (https://kind.sigs.k8s.io/) is used as
it doesn't update the default kube config.
  • Loading branch information
glyn committed Oct 8, 2019
1 parent 9e3ceab commit c364840
Show file tree
Hide file tree
Showing 12 changed files with 188 additions and 47 deletions.
6 changes: 3 additions & 3 deletions Gopkg.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Gopkg.toml
Expand Up @@ -57,7 +57,7 @@

[[constraint]]
name = "github.com/deislabs/cnab-go"
version = "v0.4.0-beta1"
version = "v0.6.0-beta1"

[[override]]
name = "github.com/google/go-containerregistry"
Expand Down
22 changes: 9 additions & 13 deletions vendor/github.com/deislabs/cnab-go/action/action.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

45 changes: 45 additions & 0 deletions vendor/github.com/deislabs/cnab-go/bundle/definition/validators.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 14 additions & 0 deletions vendor/github.com/deislabs/cnab-go/bundle/outputs.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 14 additions & 0 deletions vendor/github.com/deislabs/cnab-go/bundle/parameters.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion vendor/github.com/deislabs/cnab-go/claim/claim.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

40 changes: 39 additions & 1 deletion vendor/github.com/deislabs/cnab-go/driver/docker/docker.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions vendor/github.com/deislabs/cnab-go/driver/driver.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit c364840

Please sign in to comment.