Skip to content
This repository has been archived by the owner on May 3, 2022. It is now read-only.

feat: add interactive prompts to credential set generator #338

Merged
merged 2 commits into from
Nov 5, 2018

Conversation

technosophos
Copy link
Member

This is an attempt to make duffle credentials generate easier to use. This prompts the user to enter values for each credential as they go, instead of requiring the user to merely edit the credential file by hand.

To test, run duffle creds gen on your favorite bundle. Use the new --dry-run flag to test the prompt without writing the file.

@technosophos technosophos self-assigned this Nov 2, 2018
@technosophos technosophos added this to In progress in MVP via automation Nov 2, 2018
@itowlson
Copy link
Contributor

itowlson commented Nov 2, 2018

How is this intended to interact with programmatic environments? I can't see an option to silently generate a credentialset - is the idea that we document the credentialset file layout and format, and tooling should write directly to that? It might be good to have a --silent or --infer-empty flag or something that preserves the old behaviour... thoughts?

@technosophos technosophos moved this from In progress to Needs review in MVP Nov 2, 2018
Copy link
Contributor

@bacongobbler bacongobbler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do agree with @itowlson's comment about somehow bringing back the old look and feel through a feature flag, however I don't think it needs to be implemented for this to go through. Shall we open a new ticket for that?

MVP automation moved this from Needs review to Reviewer approved Nov 2, 2018
@technosophos
Copy link
Member Author

I will add a --no-prompt version that behaves like the older version.

@technosophos
Copy link
Member Author

@itowlson I added a --no-prompt/-q flag that restores the previous behavior.

This is an attempt to make `duffle credentials generate` easier to use. This prompts the user to enter values for each credential as they go, instead of requiring the user to merely edit the credential file by hand.

To test, run `duffle creds gen` on your favorite bundle. Use the new `--dry-run` flag to test the prompt without writing the file.
@technosophos
Copy link
Member Author

Rebased

Copy link
Member

@radu-matei radu-matei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I absolutely love this ❤️

LGTM!

@technosophos technosophos merged commit d7d21c3 into cnabio:master Nov 5, 2018
MVP automation moved this from Reviewer approved to Done Nov 5, 2018
@technosophos technosophos deleted the feat/credential-set-survey branch November 5, 2018 16:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
MVP
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants