-
Notifications
You must be signed in to change notification settings - Fork 54
feat: add interactive prompts to credential set generator #338
feat: add interactive prompts to credential set generator #338
Conversation
How is this intended to interact with programmatic environments? I can't see an option to silently generate a credentialset - is the idea that we document the credentialset file layout and format, and tooling should write directly to that? It might be good to have a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do agree with @itowlson's comment about somehow bringing back the old look and feel through a feature flag, however I don't think it needs to be implemented for this to go through. Shall we open a new ticket for that?
I will add a |
@itowlson I added a |
This is an attempt to make `duffle credentials generate` easier to use. This prompts the user to enter values for each credential as they go, instead of requiring the user to merely edit the credential file by hand. To test, run `duffle creds gen` on your favorite bundle. Use the new `--dry-run` flag to test the prompt without writing the file.
bc99618
to
0e8cd04
Compare
Rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I absolutely love this ❤️
LGTM!
This is an attempt to make
duffle credentials generate
easier to use. This prompts the user to enter values for each credential as they go, instead of requiring the user to merely edit the credential file by hand.To test, run
duffle creds gen
on your favorite bundle. Use the new--dry-run
flag to test the prompt without writing the file.