This repository has been archived by the owner on May 3, 2022. It is now read-only.
fix: Switch from ARM Template params to JSON Schema params #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
radu-matei
reviewed
Mar 11, 2019
radu-matei
approved these changes
Mar 11, 2019
technosophos
force-pushed
the
fix/648-update-param-validators
branch
from
c8a550a
to
6c98a65
Compare
|
Updated with a pointer to the explanation here. |
|
Note that this is going to be a breaking change for downstream tooling, which parses the bundle's |
|
Oh! Good catch @itowlson ! |
This was referenced Mar 12, 2019
radu-matei
force-pushed
the
fix/648-update-param-validators
branch
from
6c98a65
to
7d8b81f
Compare
|
As this also touches on Thanks! |
michelleN
approved these changes
Apr 5, 2019
| MaxLength *int `json:"maxLength,omitempty" mapstructure:"maxLength,omitempty"` | ||
| Pattern string `json:"pattern,omitempty" mapstructure:"pattern,omitempty"` | ||
| Enum []interface{} `json:"enum,omitempty" mapstructure:"enum,omitempty"` | ||
| Metadata ParameterMetadata `json:"metadata,omitempty" mapstructure:"metadata,omitempty"` |
There was a problem hiding this comment.
Should Metadata be Description?
There was a problem hiding this comment.
Looking at the parameter definition from the spec:
metadata: Holds fields that are not used in validation (OPTIONAL)description: A user-friendly description of the parameter
And it's the same here.
|
This is outdated. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to JSON Schema's keywords for validators, add pattern validator and exclusive[Min|Max] validators.
Also, refactored the tests to (a) increase coverage, and (b) reduce boilerplate.
Closes #648