This repository has been archived by the owner on May 3, 2022. It is now read-only.
Update action.Action interface #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijc
approved these changes
Apr 1, 2019
|
The linter is failing on |
|
@radu-matei I think I don't have access to the logs of the |
radu-matei
reviewed
Apr 3, 2019
pkg/action/install.go
Outdated
| @@ -13,6 +13,9 @@ type Install struct { | |||
| Driver driver.Driver // Needs to be more than a string | |||
| } | |||
|
|
|||
| // makes sure Install implements Action interface | |||
| var _ Action = &Install{} | |||
There was a problem hiding this comment.
I think we used to put this check in _test.go files, but I'm not sure this is consistent across the entire code base.
There was a problem hiding this comment.
I moved them to their respective test files 👍
silvin-lubecki
force-pushed
the
update-action-interface
branch
2 times, most recently
from
e8d78dd
to
39ebb61
Compare
|
PTAL @radu-matei @michelleN |
Add static guards to check the actions implements the interface. Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
silvin-lubecki
force-pushed
the
update-action-interface
branch
from
39ebb61
to
f8c4ef4
Compare
|
Rebased on top of master. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the action implementations added a 3rd argument
io.Writer, but this change was never reflected to the actual interfaceaction.Action.I also added static guards to check the actions implements the interface.
Signed-off-by: Silvin Lubecki silvin.lubecki@docker.com