Skip to content
This repository has been archived by the owner on May 3, 2022. It is now read-only.

Bump cnab-go dependency to reflect the Bundle structure changes #788

Merged
merged 2 commits into from Jun 24, 2019
Merged

Bump cnab-go dependency to reflect the Bundle structure changes #788

merged 2 commits into from Jun 24, 2019

Conversation

jcsirot
Copy link
Contributor

@jcsirot jcsirot commented Jun 24, 2019

  • split parameters into parameters and definitions
  • added JSON Schema support for parameter validation
  • replaced bundle.Location by the dedicated struct bundle.Credential

Synchronize with cnab-go master branch and adapt the code and tests t…
0f81593 
…o reflect the Bundle structure changes (Split parameters into parameters and definition, added JSON Schema support, replaced bundle.Location by bundle.Credential)

Signed-off-by: Jean-Christophe Sirot <jean-christophe.sirot@docker.com>
@jeremyrickard
Copy link
Member

jeremyrickard commented Jun 24, 2019 •
edited

Hey @jcsirot, thanks for opening this. I was in the process of doing this, so you're saving the day for me! The only thing I think we should change here is adding a dependency on a released version of cnab-go. I just did a release to include the nil pointer de-reference change that you submitted, so ideally we should add a constraint on that verison of cnab-go here, instead of keeping up with master..something like

[[constraint]]
  name = "github.com/deislabs/cnab-go"
  version = "v0.1.2-beta1"

What do you think?

jeremyrickard
jeremyrickard suggested changes Jun 24, 2019
View reviewed changes
Copy link
Member

@jeremyrickard jeremyrickard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a constraint to lock to a released version of cnab-go.

@jcsirot
Copy link
Contributor Author

jcsirot commented Jun 24, 2019

@jeremyrickard Indeed, good point. I fixed that.

Set a dependency constraint on cnab-go v0.1.2-beta1
2e09a10 
Signed-off-by: Jean-Christophe Sirot <jean-christophe.sirot@docker.com>
silvin-lubecki
silvin-lubecki approved these changes Jun 24, 2019
View reviewed changes
Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jeremyrickard
jeremyrickard approved these changes Jun 24, 2019
View reviewed changes
Copy link
Member

@jeremyrickard jeremyrickard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeremyrickard
Copy link
Member

/brig run

@jeremyrickard jeremyrickard merged commit 5930527 into cnabio:master Jun 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silvin-lubecki silvin-lubecki silvin-lubecki approved these changes

@jeremyrickard jeremyrickard jeremyrickard approved these changes

@bacongobbler bacongobbler Awaiting requested review from bacongobbler

@carolynvs carolynvs Awaiting requested review from carolynvs carolynvs is a code owner

@glyn glyn Awaiting requested review from glyn

@radu-matei radu-matei Awaiting requested review from radu-matei radu-matei is a code owner

@technosophos technosophos Awaiting requested review from technosophos technosophos is a code owner

@vdice vdice Awaiting requested review from vdice vdice is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jcsirot @jeremyrickard @silvin-lubecki