-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tw] Add content/zh-tw/container.md #2052
Conversation
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@cdxvy30 Please remember to sign the DCO and indicate "Signed-off-by:" within the git commit |
@cdxvy30 Could you please merge these two commits using the squash method into a singular commit? |
Sure, I have squashed both commits into one. Please help review, thanks. If there are still any mistakes, please correct me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the style guide, one sentence per line is recommended, following the original.
Fix it. Also modify the category in the front matter according to the original (technology). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, my review is complete after merging two commits into one commit using the squash method.
Fix the description from "電腦" to "計算機". Please help review, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,thanks @cdxvy30
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Cody Chen <cdxvy30@gmail.com> Update content/zh-tw/container.md Signed-off-by: Cody Chen <cdxvy30@gmail.com> Update content/zh-tw/container.md Signed-off-by: cdxvy30 <cdxvy30@gmail.com> Add content/zh-tw/container.md Signed-off-by: cdxvy30 <cdxvy30@gmail.com>
Describe your changes
Add new translation term: container
Original content from: https://glossary.cncf.io/container
Related issue number or link (ex:
resolves #issue-number
)resolve #2037
Checklist before opening this PR (put
x
in the checkboxes)git commit -s
) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfig
by runninggit config --global alias.ci "commit -s"
.