Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tw] Add content/zh-tw/container.md #2052

Merged
merged 1 commit into from
Jun 5, 2023
Merged

[tw] Add content/zh-tw/container.md #2052

merged 1 commit into from
Jun 5, 2023

Conversation

cdxvy30
Copy link
Contributor

@cdxvy30 cdxvy30 commented May 16, 2023

Describe your changes

Add new translation term: container
Original content from: https://glossary.cncf.io/container

Related issue number or link (ex: resolves #issue-number)

resolve #2037

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

@netlify
Copy link

netlify bot commented May 16, 2023

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 9d25804
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/647cca1935d9c10008fa3430
😎 Deploy Preview https://deploy-preview-2052--cncfglossary.netlify.app/zh-tw/container
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ydFu ydFu added the lang/tw for Traditional Chinese label May 16, 2023
@ydFu ydFu linked an issue May 16, 2023 that may be closed by this pull request
content/zh-tw/container.md Outdated Show resolved Hide resolved
content/zh-tw/container.md Outdated Show resolved Hide resolved
content/zh-tw/container.md Outdated Show resolved Hide resolved
content/zh-tw/container.md Outdated Show resolved Hide resolved
@pichuang
Copy link
Contributor

@cdxvy30 Please remember to sign the DCO and indicate "Signed-off-by:" within the git commit

@pichuang
Copy link
Contributor

@cdxvy30 Could you please merge these two commits using the squash method into a singular commit?

https://docs.github.com/en/desktop/contributing-and-collaborating-using-github-desktop/managing-commits/squashing-commits-in-github-desktop

@cdxvy30
Copy link
Contributor Author

cdxvy30 commented May 30, 2023

Sure, I have squashed both commits into one. Please help review, thanks. If there are still any mistakes, please correct me.

Copy link
Collaborator

@ydFu ydFu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the style guide, one sentence per line is recommended, following the original.

https://glossary.cncf.io/style-guide/#three-subheadings

content/zh-tw/container.md Outdated Show resolved Hide resolved
content/zh-tw/container.md Outdated Show resolved Hide resolved
content/zh-tw/container.md Outdated Show resolved Hide resolved
content/zh-tw/container.md Outdated Show resolved Hide resolved
content/zh-tw/container.md Outdated Show resolved Hide resolved
content/zh-tw/container.md Outdated Show resolved Hide resolved
@cdxvy30
Copy link
Contributor Author

cdxvy30 commented May 31, 2023

Fix it. Also modify the category in the front matter according to the original (technology).

Copy link
Collaborator

@ydFu ydFu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, my review is complete after merging two commits into one commit using the squash method.

content/zh-tw/container.md Outdated Show resolved Hide resolved
@cdxvy30
Copy link
Contributor Author

cdxvy30 commented May 31, 2023

Fix the description from "電腦" to "計算機". Please help review, thanks!

Copy link
Collaborator

@ydFu ydFu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,thanks @cdxvy30

Copy link
Contributor

@pichuang pichuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Cody Chen <cdxvy30@gmail.com>

Update content/zh-tw/container.md

Signed-off-by: Cody Chen <cdxvy30@gmail.com>

Update content/zh-tw/container.md

Signed-off-by: cdxvy30 <cdxvy30@gmail.com>

Add content/zh-tw/container.md

Signed-off-by: cdxvy30 <cdxvy30@gmail.com>
@ydFu ydFu merged commit d8fd66f into cncf:dev-tw Jun 5, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/tw for Traditional Chinese
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tw] Localize Containers for Traditional Chinese
3 participants