Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tw] Localize Shift Left for Traditional Chinese #2281

Merged
merged 1 commit into from Aug 14, 2023

Conversation

johnlinp
Copy link
Collaborator

@johnlinp johnlinp commented Aug 9, 2023

Describe your changes

Origin content from https://glossary.cncf.io/shift-left/

Related issue number or link (ex: resolves #issue-number)

resolves #2279

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

@netlify
Copy link

netlify bot commented Aug 9, 2023

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 27c18b4
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/64d97eeeca9e330008516d72
😎 Deploy Preview https://deploy-preview-2281--cncfglossary.netlify.app/zh-tw/shift-left
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the lang/tw for Traditional Chinese label Aug 9, 2023
content/zh-tw/shift-left.md Outdated Show resolved Hide resolved
content/zh-tw/shift-left.md Outdated Show resolved Hide resolved
content/zh-tw/shift-left.md Outdated Show resolved Hide resolved
@ydFu ydFu linked an issue Aug 10, 2023 that may be closed by this pull request
@johnlinp
Copy link
Collaborator Author

感謝 @hwchiu 的 review!

Copy link
Collaborator

@hwchiu hwchiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

content/zh-tw/shift-left.md Outdated Show resolved Hide resolved
content/zh-tw/shift-left.md Outdated Show resolved Hide resolved
content/zh-tw/shift-left.md Outdated Show resolved Hide resolved
content/zh-tw/shift-left.md Outdated Show resolved Hide resolved
content/zh-tw/shift-left.md Outdated Show resolved Hide resolved
@johnlinp
Copy link
Collaborator Author

@ydFu 感謝 review! 我已經把你的 suggestions 都按 commit 了,再麻煩你確認,謝謝。

@johnlinp johnlinp requested a review from ydFu August 13, 2023 06:28
@ydFu
Copy link
Collaborator

ydFu commented Aug 14, 2023

LGTM.
Use rebase to squash/fixup dummy/unnecessary commits into only one commit.

Signed-off-by: John Lin <johnlinp@gmail.com>
@johnlinp
Copy link
Collaborator Author

@ydFu 完成!

Copy link
Collaborator

@ydFu ydFu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,thank @johnlinp

Copy link
Contributor

@pichuang pichuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pichuang pichuang merged commit a5f97cd into cncf:dev-tw Aug 14, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/tw for Traditional Chinese
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tw] Localize Shift Left for Traditional Chinese
4 participants