Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tw] Localize Site Reliabilitgy Engineering for Traditional Chinese (#2372) #2398

Merged
merged 1 commit into from
Sep 17, 2023

Conversation

Fionn88
Copy link
Contributor

@Fionn88 Fionn88 commented Sep 15, 2023

Describe your changes

Origin content from https://glossary.cncf.io/site-reliability-engineering/

Related issue number or link (ex: resolves #issue-number)

resolves #2372
fix #2384

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

@netlify
Copy link

netlify bot commented Sep 15, 2023

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 8607180
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/650599063c125f0009d0bec0
😎 Deploy Preview https://deploy-preview-2398--cncfglossary.netlify.app/zh-tw/site-reliability-engineering
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the lang/tw for Traditional Chinese label Sep 15, 2023
@ydFu ydFu linked an issue Sep 15, 2023 that may be closed by this pull request
@Fionn88
Copy link
Contributor Author

Fionn88 commented Sep 15, 2023

I've made the changes as suggested.
Thank you for your review!

…ncf#2372)

Signed-off-by: Yuan-Heng,Kuo <coco8802231225@gmail.com>
Copy link
Collaborator

@ydFu ydFu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,thanks for @Fionn88

Copy link
Contributor

@pichuang pichuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pichuang pichuang merged commit 8f63973 into cncf:dev-tw Sep 17, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/tw for Traditional Chinese
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tw] Localize Site Reliability Engineering for Traditional Chinese
3 participants