Sync branch dev-tw from main(20231031) #2572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julia Furst Morgado <52685951+juliafmorgado@users.noreply.github.com>
Added a line break after each sentence. Signed-off-by: Julia Furst Morgado <52685951+juliafmorgado@users.noreply.github.com>
Improved version of the definition with a better flow and clarity. Signed-off-by: Julia Furst Morgado <52685951+juliafmorgado@users.noreply.github.com>
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
ydFu
added
maintainers
ydFu
requested review from
caniszczyk,
seokho-son,
iamNoah1,
jihoon-seo and
nate-double-u
as code owners
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
28 tasks
Co-authored-by: Nate W <natew@cncf.io> Signed-off-by: Julia Furst Morgado <52685951+juliafmorgado@users.noreply.github.com>
Update role-based-access-control.md
seokho-son
approved these changes
Oct 31, 2023
There was a problem hiding this comment.
Thanks @ydFu for maintaining the dev branch. :)
LGTM. Let me merge the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The main reason for this change is that when dev-tw was first merged into the main branch, a necessary sub-task was to update dev-tw to the latest main, so this change was proposed.
Because the main and dev-tw branches are currently in a parallel state, updates from PR(#2566) need to be resubmitted to update dev-tw to the latest main.
Related issue number or link (ex:
resolves #issue-number)#2566
Checklist before opening this PR (put
xin the checkboxes)git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfigby runninggit config --global alias.ci "commit -s".