Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Virtual Private Cloud #992

Closed
wants to merge 4 commits into from
Closed

Added Virtual Private Cloud #992

wants to merge 4 commits into from

Conversation

akshatcoder-hash
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Jun 25, 2022 •
edited
Loading

✅ Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 8a6d01e
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/62b98b052437a80008dd31b7
😎 Deploy Preview https://deploy-preview-992--cncfglossary.netlify.app/virtual-private-cloud
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@akshatcoder-hash akshatcoder-hash mentioned this pull request Jun 25, 2022
Closed
@jihoon-seo jihoon-seo added lang/en for English maintainers Use this label if PR requires maintainers to take action labels Jun 25, 2022
@jihoon-seo jihoon-seo linked an issue Jun 25, 2022 that may be closed by this pull request
[English]: Virtual Private Cloud (VPC) #613
Closed
3 tasks
iamNoah1
iamNoah1 requested changes Jun 25, 2022
View reviewed changes
Copy link
Collaborator

@iamNoah1 iamNoah1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @akshatcoder-hash.

Some feedback:

  • Please use semantic line breaks
  • Please don't use bullet points, instead write complete sentences
  • See the Spellcheck
  • Sign your commits

@jihoon-seo jihoon-seo mentioned this pull request Jun 25, 2022
Closed
@jihoon-seo jihoon-seo removed the maintainers Use this label if PR requires maintainers to take action label Jun 25, 2022
@CathPag
Copy link
Collaborator

CathPag commented Jun 27, 2022

@akshatcoder-hash, there are two PRs for this. This one and #994. Which is the one we should review? Please close the outdated one.

@akshatcoder-hash
Copy link
Contributor Author

Done that @CathPag!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamNoah1 iamNoah1 iamNoah1 requested changes

@caniszczyk caniszczyk Awaiting requested review from caniszczyk caniszczyk is a code owner

@CathPag CathPag Awaiting requested review from CathPag

@JasonMorgan JasonMorgan Awaiting requested review from JasonMorgan

@seokho-son seokho-son Awaiting requested review from seokho-son seokho-son is a code owner

@jihoon-seo jihoon-seo Awaiting requested review from jihoon-seo jihoon-seo is a code owner

Assignees
No one assigned
Labels
lang/en for English
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[English]: Virtual Private Cloud (VPC)
4 participants
@akshatcoder-hash @CathPag @iamNoah1 @jihoon-seo