Skip to content

Commit

Permalink
Added additional versions.txt validation rules.
Browse files Browse the repository at this point in the history
Under the current description, a 1.7 cluster could theoretically certify for 1.8 by passing the 1.8 tests, which was not the intention.
– Specifies that the server version must match the Conformance Version
– Supports version skew on the tests for now.
  • Loading branch information
WilliamDenniss committed Nov 1, 2017
1 parent cc5edd4 commit 19212f4
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions reviewing.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,13 @@ Kubernetes for which conformance is being claimed, referenced as the
3. Verify that the Conformance Version is the current or previous version of
Kubernetes.

4. Look at `version.txt`. Verify that the `client` version matches the
Conformance Version to a minor version level (the patch version may differ).
`client` in this file represents the version of the e2e tests that were run.
4. Look at `version.txt`. Verify that the `major.minor` component of the
`server` version exactly matches the Conformance Version.

5. Verify that the last line of `e2e.log` says "SUCCESS! -- `N` Passed | 0
5. Look at `version.txt`. Verify that the `major.minor` component of the
`client` version (which represents the Kubernetes version of the e2e tests that
were run) is equal to or greater than the Conformance Version.

6. Verify that the last line of `e2e.log` says "SUCCESS! -- `N` Passed | 0
Failed | 0 Pending | `M` Skipped PASS". The exact value of `N` and `M` don't
matter as long as we see `0 Failed | 0 Pending`.

0 comments on commit 19212f4

Please sign in to comment.