Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taylorwaggoner update ads #1376

Merged
merged 5 commits into from
Aug 23, 2019
Merged

Taylorwaggoner update ads #1376

merged 5 commits into from
Aug 23, 2019

Conversation

taylorwaggoner
Copy link
Contributor

@taylorwaggoner taylorwaggoner commented Aug 22, 2019

Pre-submission checklist:

Please check each of these after submitting your pull request:

  • Are you only including a repo_url if your project is 100% open source? If so, you need to pick the single best GitHub repository for your project, not a GitHub organization.
  • Is your project closed source or, if it is open source, does your project have at least 250 GitHub stars?
  • Have you picked the single best (existing) category for your project?
  • Does it follow the other guidelines from the new entries section?
  • Have you included a URL for your SVG or added it to hosted_logos and referenced it there?
  • Does your logo clearly state the name of the project/product and follow the other logo guidelines?
  • Does your project/product name match the text on the logo?
  • Have you verified that the Crunchbase data for your organization is correct (including headquarters and LinkedIn)?
  • ~5 minutes after opening the pull request, the CNCF-Bot will post the URL for your staging server. Have you confirmed that it looks good to you and then added a comment to the PR saying "LGTM"?

@CNCF-Bot
Copy link
Contributor

CNCF-Bot commented Aug 22, 2019

Deploy preview for landscape ready!

Built with commit c052503

https://deploy-preview-1376--landscape.netlify.com

@taylorwaggoner
Copy link
Contributor Author

LGTM

@dankohn
Copy link
Contributor

dankohn commented Aug 22, 2019

This isn't good because the nav bar now scrolls. @ZeusTheTrueGod could you please add some logic so that if the second logo is empty, it doesn't show.

@AndreyKozlov1984
Copy link
Contributor

I've just removed a second ad, we already support an array of ads

@AndreyKozlov1984
Copy link
Contributor

LGTM

@dankohn
Copy link
Contributor

dankohn commented Aug 23, 2019

Great, thanks for confirming.

@dankohn dankohn merged commit b29ed13 into master Aug 23, 2019
@dankohn dankohn deleted the taylorwaggoner-update-ads branch August 23, 2019 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants