(Do not merge) displays latest tweet date, closes #321 #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for landscape ready! Built with commit ac92616 |
|
Deploy preview for landscape ready! Built with commit a0fe5ff |
|
Deploy preview for landscape ready! Built with commit f176177 |
|
Can you please fix the order of the fields on mobile. It should show Twitter handle and then last tweet.
|
|
And please add a sort by last tweet. |
dankohn
reviewed
Mar 24, 2018
tools/twitter.js
Outdated
| try { | ||
| source = require('js-yaml').safeLoad(require('fs').readFileSync('processed_landscape.yml')); | ||
| } catch(_ex) { | ||
| console.info('Cannot extract image entries from the processed_landscape.yml'); |
There was a problem hiding this comment.
Should this be Cannot extract Twitter entries...
|
Twitter address fixes: 93f668a You will need to run again in an hour to pickup changes on Crunchbase. |
|
Ok, I'll run this again. |
|
And will add a requirement that a twitter is valid |
|
@dankohn , here is a list of issues with twitter in our data: |
|
Beside that, this is ready to merge |
Signed-off-by: Dan Kohn <dan@dankohn.com>
Signed-off-by: Dan Kohn <dan@dankohn.com>
AndreyKozlov1984
added a commit
to AndreyKozlov1984/landscape
that referenced
this pull request
Nov 18, 2018
* wip: latest tweet date * taking a proper twitter account * support a proper twitter account * handle a case when there are no tweets at all * do not repeat twitter entries * calculating an effective twitter * show latest tweet together with a twitter name when on a mobile device * allow to sort by a latest tweet date * fix a twitter link * new data after yarn update * OpenContrail twitter fix * rename effectiveTwitter to actualTwitter * do not allow entries with an empty or invalid twitter * Merge master and yarn fetch Signed-off-by: Dan Kohn <dan@dankohn.com>
AndreyKozlov1984
added a commit
to AndreyKozlov1984/landscape
that referenced
this pull request
Nov 18, 2018
* wip: latest tweet date * taking a proper twitter account * support a proper twitter account * handle a case when there are no tweets at all * do not repeat twitter entries * calculating an effective twitter * show latest tweet together with a twitter name when on a mobile device * allow to sort by a latest tweet date * fix a twitter link * new data after yarn update * OpenContrail twitter fix * rename effectiveTwitter to actualTwitter * do not allow entries with an empty or invalid twitter * Merge master and yarn fetch Signed-off-by: Dan Kohn <dan@dankohn.com> Former-commit-id: e2e0d5e
AndreyKozlov1984
added a commit
to AndreyKozlov1984/landscape
that referenced
this pull request
Nov 18, 2018
* wip: latest tweet date * taking a proper twitter account * support a proper twitter account * handle a case when there are no tweets at all * do not repeat twitter entries * calculating an effective twitter * show latest tweet together with a twitter name when on a mobile device * allow to sort by a latest tweet date * fix a twitter link * new data after yarn update * OpenContrail twitter fix * rename effectiveTwitter to actualTwitter * do not allow entries with an empty or invalid twitter * Merge master and yarn fetch Signed-off-by: Dan Kohn <dan@dankohn.com> Former-commit-id: e2e0d5e
AndreyKozlov1984
added a commit
that referenced
this pull request
Nov 18, 2018
* wip: latest tweet date * taking a proper twitter account * support a proper twitter account * handle a case when there are no tweets at all * do not repeat twitter entries * calculating an effective twitter * show latest tweet together with a twitter name when on a mobile device * allow to sort by a latest tweet date * fix a twitter link * new data after yarn update * OpenContrail twitter fix * rename effectiveTwitter to actualTwitter * do not allow entries with an empty or invalid twitter * Merge master and yarn fetch Signed-off-by: Dan Kohn <dan@dankohn.com>
AndreyKozlov1984
added a commit
that referenced
this pull request
Nov 19, 2018
* wip: latest tweet date * taking a proper twitter account * support a proper twitter account * handle a case when there are no tweets at all * do not repeat twitter entries * calculating an effective twitter * show latest tweet together with a twitter name when on a mobile device * allow to sort by a latest tweet date * fix a twitter link * new data after yarn update * OpenContrail twitter fix * rename effectiveTwitter to actualTwitter * do not allow entries with an empty or invalid twitter * Merge master and yarn fetch Signed-off-by: Dan Kohn <dan@dankohn.com>
AndreyKozlov1984
added a commit
that referenced
this pull request
Dec 28, 2018
* wip: latest tweet date * taking a proper twitter account * support a proper twitter account * handle a case when there are no tweets at all * do not repeat twitter entries * calculating an effective twitter * show latest tweet together with a twitter name when on a mobile device * allow to sort by a latest tweet date * fix a twitter link * new data after yarn update * OpenContrail twitter fix * rename effectiveTwitter to actualTwitter * do not allow entries with an empty or invalid twitter * Merge master and yarn fetch Signed-off-by: Dan Kohn <dan@dankohn.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please don't merge this yet, because I have not added fatal checks for a lack of twitter.
And I will not add them until you preview and tell how this looks like or I can not build and can not show anything