Set fixed urls relative to language #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lianmakesthings
requested review from
AloisReitbauer,
thschue,
joshgav,
kgamanji,
angellk,
abangser and
roberthstrand
as code owners
Action RequiredYou are adding or updating English content so please take the following actions for other languages.
|
✅ Deploy Preview for tag-app-delivery ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: lianmakesthings <hi@lianmakesthings.dev>
lianmakesthings
force-pushed
the
fix_whitepaper_backlinks
branch
from
21b98c4
to
0b79fda
Compare
lianmakesthings
changed the title
roberthstrand
approved these changes
Apr 21, 2024
This was referenced Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #626
Originally, we set fixed URLs for the whitepapers.
When these were duplicated due to the new script for language support, they also copied the fix URL. That would lead to issues, like the default page being hijacked by a non-default language.
By removing the fixed URL, we solved the language issue, but broke backlinks to the whitepapers.
According to hugos docs, for multilingual support, fixed URLs need to be set relative to the languagecode.
This PR should bring back the fix URL, so it always points to the default language version (English) while the other languages will include their language code in the URL.