Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TAG's Working Groups section and Green Reviews WG #151

Merged
merged 15 commits into from Aug 14, 2023
Merged

Add TAG's Working Groups section and Green Reviews WG #151

merged 15 commits into from Aug 14, 2023

Conversation

guidemetothemoon
Copy link
Contributor

@guidemetothemoon guidemetothemoon commented Jul 15, 2023

This PR adds Green Reviews Working Group to Environmental Sustainability TAG repo and website.

GitHub issues: #116 , #64
Authors: @guidemetothemoon, @nikimanoledaki, @leonardpahlke
TAG ENV WG Green Reviews Proposal Document: https://docs.google.com/document/d/18MkLryOSbZpSsgl_ileLbHp_K4xn8TqxMzcHDtNuY_o/edit?usp=sharing

Since Green Reviews Working Group is the first WG to be added, this PR also adds folder structure and information about TAG's Working Groups in the TAG's repo as well as on the TAG's website.
Working Groups section has been added as About subsection on the website:
image

@netlify
Copy link

netlify bot commented Jul 15, 2023

Deploy Preview for tag-env-sustainability ready!

Name Link
🔨 Latest commit 7b6a39d
🔍 Latest deploy log https://app.netlify.com/sites/tag-env-sustainability/deploys/64ca5d520bada50008045c71
😎 Deploy Preview https://deploy-preview-151--tag-env-sustainability.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Kristina Devochko <guidemetothemoon@gmail.com>
Signed-off-by: Kristina Devochko <guidemetothemoon@gmail.com>
Signed-off-by: Kristina Devochko <guidemetothemoon@gmail.com>
@guidemetothemoon guidemetothemoon marked this pull request as ready for review July 15, 2023 15:30
@guidemetothemoon
Copy link
Contributor Author

Thank you to everyone who has reviewed this proposal until now and came with valuable suggestions and comments. Reviews, comments and suggestions to this PR are very welcome!

@guidemetothemoon guidemetothemoon changed the title Add TAG Working Groups section and Green Reviews WG Add TAG's Working Groups section and Green Reviews WG Jul 15, 2023
Copy link
Contributor

@nikimanoledaki nikimanoledaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's happening! Added a couple of extra refs to the WG definition. Thank you Kristina for bootstrapping the WG structure 😄

working-groups/green-reviews/README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
guidemetothemoon and others added 3 commits July 15, 2023 19:40
Co-authored-by: Niki <niki.manoledaki@grafana.com>
Signed-off-by: Kris - The Coding Unicorn <47773700+guidemetothemoon@users.noreply.github.com>
Co-authored-by: Niki <niki.manoledaki@grafana.com>
Signed-off-by: Kris - The Coding Unicorn <47773700+guidemetothemoon@users.noreply.github.com>
Co-authored-by: Niki <niki.manoledaki@grafana.com>
Signed-off-by: Kris - The Coding Unicorn <47773700+guidemetothemoon@users.noreply.github.com>
Copy link

@roberthstrand roberthstrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍

working-groups/green-reviews/README.md Outdated Show resolved Hide resolved
working-groups/green-reviews/README.md Outdated Show resolved Hide resolved
working-groups/green-reviews/README.md Outdated Show resolved Hide resolved
website/content/about/working-groups.md Outdated Show resolved Hide resolved
guidemetothemoon and others added 2 commits July 17, 2023 17:54
Co-authored-by: Leonard Vincent Simon Pahlke <58054077+leonardpahlke@users.noreply.github.com>
Signed-off-by: Kris - The Coding Unicorn <47773700+guidemetothemoon@users.noreply.github.com>
Signed-off-by: Kristina Devochko <guidemetothemoon@gmail.com>
guidemetothemoon and others added 3 commits July 19, 2023 22:16
Co-authored-by: Leonard Vincent Simon Pahlke <58054077+leonardpahlke@users.noreply.github.com>
Signed-off-by: Kris - The Coding Unicorn <47773700+guidemetothemoon@users.noreply.github.com>
Signed-off-by: Kristina Devochko <guidemetothemoon@gmail.com>
Copy link
Contributor

@TheFoxAtWork TheFoxAtWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, some questions on the nomination/ endorsement process

governance/working-group-chair-proposal-process.md Outdated Show resolved Hide resolved
governance/working-group-chair-proposal-process.md Outdated Show resolved Hide resolved
governance/working-group-chair-proposal-process.md Outdated Show resolved Hide resolved
Copy link
Member

@nikhita nikhita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a question about scope but looks great otherwise!

Thanks for including an explicit process around nomination too 👍

working-groups/green-reviews/charter.md Show resolved Hide resolved
guidemetothemoon and others added 4 commits July 31, 2023 11:42
Co-authored-by: Emily Fox <33327273+TheFoxAtWork@users.noreply.github.com>
Signed-off-by: Kris - The Coding Unicorn <47773700+guidemetothemoon@users.noreply.github.com>
Signed-off-by: Kristina Devochko <guidemetothemoon@gmail.com>
Signed-off-by: Kristina Devochko <guidemetothemoon@gmail.com>
Copy link
Member

@leonardpahlke leonardpahlke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkorbi
Copy link
Member

mkorbi commented Aug 3, 2023

LGTM
Let's go!

@leonardpahlke
Copy link
Member

Great! Now we are looking for a review from our TOC Liaisons @TheFoxAtWork @mattfarina @erinaboyd could you take a look? Thanks :)

Copy link
Contributor

@TheFoxAtWork TheFoxAtWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks absolutely wonderful and well defined. Thank you!

@leonardpahlke leonardpahlke merged commit 0174c7a into cncf:main Aug 14, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants