Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assessments/projects: add in-toto self assessment #202

Merged
merged 3 commits into from
Jun 18, 2019

Conversation

SantiagoTorres
Copy link
Contributor

This relates to issue #166

This adds a markdown version of the self assessment for in-toto.

cc @ultrasaurus @JustinCappos @justincormack @lumjjb

Copy link
Member

@ultrasaurus ultrasaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some formatting feedback, otherwise looks good

assessments/projects/in-toto/self-assesment.md Outdated Show resolved Hide resolved

June 5, 2019

*_Authors_*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line breaks below don't appear in rendered markdown, so I think it would be a little more readable if it was

Authors: name, name, name

keeping markdown source as separate lines for easier reading/diffing of source

assessments/projects/in-toto/self-assesment.md Outdated Show resolved Hide resolved
It is possible to reach out the in-toto team members at:

* #in-toto@irc.freenode.net
* The #in-toto channel at secure-systems-lab.slack.com
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice to link "secure-systems-lab.slack.com" to wherever it's listed how to get an invite. If I just go there in slack, it says:
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unless that is intended for core team only and public should access via in-toto freenode, if that's the case, just note that please

@SantiagoTorres
Copy link
Contributor Author

Thanks for the review @ultrasaurus. I think I addressed all the comments and I'm ready for another review 👍

Copy link
Member

@ultrasaurus ultrasaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ultrasaurus ultrasaurus merged commit 10b9923 into cncf:master Jun 18, 2019
Michael-Susu12138 pushed a commit to Michael-Susu12138/tag-security that referenced this pull request Dec 12, 2023
assessments/projects: add in-toto self assessment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants