What: correcting DCO and merge conflict issues. all comments from pr… #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vious closed branch resolved. Signed-off-by: Emily Fox <themoxiefoxatwork@gmail.com>
|
Previous PR from where we got here is: |
|
Let's call a 2 week comments period on this .. Since this was filed July 29th and the previous PR has been filed way back february. Let's give it until Aug 12th and then merge. thanks! |
xmulligan
reviewed
Aug 5, 2022
Co-authored-by: Bill Mulligan <billmulligan516@gmail.com>
|
All of the changes in this seem common-sense. +1 |
Co-authored-by: Brandon Lum <lumjjb@gmail.com>
|
🚢 🚢 🚢 🚢 this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…evious closed branch resolved.
Signed-off-by: Emily Fox themoxiefoxatwork@gmail.com