-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cel: Add canonical CEL (dev.cel.expr) fields #75
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiitk
force-pushed
the
canonical-cel
branch
from
November 15, 2023 19:22
8a70387
to
e068604
Compare
sergiitk
changed the title
Add canonical CEL support: dev.cel.expr (com_github_grpc_grpc approach)
Add canonical CEL fields support
Nov 15, 2023
sergiitk
force-pushed
the
canonical-cel
branch
from
November 15, 2023 19:24
e068604
to
a0b1299
Compare
sergiitk
changed the title
Add canonical CEL fields support
Add canonical CEL fields to CelExpression
Nov 15, 2023
sergiitk
changed the title
Add canonical CEL fields to CelExpression
cel: Add canonical CEL fields
Nov 15, 2023
sergiitk
changed the title
cel: Add canonical CEL fields
cel: Add canonical CEL (dev.cel.expr) fields
Nov 15, 2023
Signed-off-by: Sergii Tkachenko <sergiitk@google.com>
sergiitk
force-pushed
the
canonical-cel
branch
from
November 16, 2023 19:32
9d949f7
to
7297c7d
Compare
@tyxia @markdroth Please review. |
markdroth
approved these changes
Nov 17, 2023
tyxia
reviewed
Nov 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
tyxia
approved these changes
Nov 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks!
sergiitk
added a commit
to sergiitk/xds
that referenced
this pull request
Nov 21, 2023
This reverts commit 0f5e0d9.
sergiitk
added a commit
to sergiitk/xds
that referenced
this pull request
Nov 21, 2023
adisuissa
pushed a commit
that referenced
this pull request
Nov 21, 2023
sergiitk
added a commit
to sergiitk/xds
that referenced
this pull request
Nov 27, 2023
sergiitk
added a commit
to sergiitk/xds
that referenced
this pull request
Nov 27, 2023
…ncf#79)" This reverts commit 5b9bca5. Reverts cncf#79. Now that cncf#78 `go build` CI is in place; this PR brings back the CEL fields. Once `del.dev` domain is fixed, we'll see the CI passing and will be able to merge this PR. Original comment --- This PR adds canonical CEL (https://github.com/google/cel-spec/tree/master/proto/cel/expr) fields to `xds.type.v3.CelExpression`. Canonical CEL `cel.expr` was created identical to the `google.api.expr.v1alpha1`, but may be extended in a backward-compatible way. Nuances: 1. The new fields `cel_expr_parsed` and `cel_expr_checked` are added outside of `oneof expr_specifier` per updated policy change: envoyproxy/envoy#30851 2. `option (validate.required) = true` is removed from the `oneof expr_specifier`, so the users may not presume one of the `parsed_expr`, `checked_expr` will be set. --- Signed-off-by: Sergii Tkachenko <sergiitk@google.com>
sergiitk
added a commit
to sergiitk/xds
that referenced
this pull request
Jan 24, 2024
…ncf#79)" This reverts commit 5b9bca5. Reverts cncf#79. Now that cncf#78 `go build` CI is in place; this PR brings back the CEL fields. Once `del.dev` domain is fixed, we'll see the CI passing and will be able to merge this PR. Original comment Signed-off-by: Sergii Tkachenko <sergiitk@google.com> --- This PR adds canonical CEL (https://github.com/google/cel-spec/tree/master/proto/cel/expr) fields to `xds.type.v3.CelExpression`. Canonical CEL `cel.expr` was created identical to the `google.api.expr.v1alpha1`, but may be extended in a backward-compatible way. Nuances: 1. The new fields `cel_expr_parsed` and `cel_expr_checked` are added outside of `oneof expr_specifier` per updated policy change: envoyproxy/envoy#30851 2. `option (validate.required) = true` is removed from the `oneof expr_specifier`, so the users may not presume one of the `parsed_expr`, `checked_expr` will be set. --- Signed-off-by: Sergii Tkachenko <sergiitk@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds canonical CEL (https://github.com/google/cel-spec/tree/master/proto/cel/expr) fields to
xds.type.v3.CelExpression
. Canonical CELcel.expr
was created identical to thegoogle.api.expr.v1alpha1
, but may be extended in a backward-compatible way.Nuances:
cel_expr_parsed
andcel_expr_checked
are added outside ofoneof expr_specifier
per updated policy change: API: change style guide to discourage use of "oneof" envoyproxy/envoy#30851option (validate.required) = true
is removed from theoneof expr_specifier
, so the users may not presume one of theparsed_expr
,checked_expr
will be set.