Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get cel.dev/expr error with go get #76

Closed
zhangbc97 opened this issue Nov 18, 2023 · 9 comments · Fixed by #89
Closed

Get cel.dev/expr error with go get #76

zhangbc97 opened this issue Nov 18, 2023 · 9 comments · Fixed by #89

Comments

@zhangbc97
Copy link

After improt github.com/cncf/xds/go/xds/type/v3 , go get command get an error

go: main imports
        github.com/cncf/xds/go/xds/type/v3 imports
        cel.dev/expr: cannot find module providing package cel.dev/expr

main.go

package main

import (
        "github.com/cncf/xds/go/xds/type/v3"
)

go.mod

module main

go 1.21
@LeVadim
Copy link

LeVadim commented Nov 18, 2023

Hello!

Same issue here:

googleapis/google-cloud-go#9031

Affecting spanner's DB Client

Best regards,
Vadim

@arhea
Copy link

arhea commented Nov 18, 2023

UPDATE: This is no longer needed as the change was rolled back until the domain settings are updated.

Temporary workaround:

replace github.com/cncf/xds => github.com/cncf/xds v0.0.0-20231116142803-3a472e524827

@LeVadim
Copy link

LeVadim commented Nov 18, 2023

It worked, thank you! @arhea

@adisuissa
Copy link

@sergiitk I think it may be due to #75. Can you PTAL?

@sergiitk
Copy link
Contributor

Yes, this is very likely due to #75. I'm not that familiar with the go ecosystem. I'll ask around.

@sergiitk
Copy link
Contributor

@l46kok
Copy link

l46kok commented Nov 20, 2023

We're looking into this -- we'll need to setup a redirect to point at the github repo, then the import should just work. We'll keep you updated

sergiitk added a commit to sergiitk/xds that referenced this issue Nov 21, 2023
This reverts commit 0f5e0d9.
Temporarily reverting the PR so that folks aren't affected by
cncf#76.
Will be brought back once CEL folks solve the domain issue.

Signed-off-by: Sergii Tkachenko <sergiitk@google.com>
@sergiitk
Copy link
Contributor

FYI #75 was rolled back last week in #79, so the temporary pinning workaround #76 (comment) is not needed.
I added CI verification job to prevent go build issues from happening again in #78.

Once CEL folks fix the domain settings, we'll bring back the CEL fields, see #81.

@arhea
Copy link

arhea commented Nov 27, 2023

Updated my comment incase people don't scroll :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants