Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump io_bazel_rules_go -> 0.46.0 #93

Merged
merged 3 commits into from
Apr 19, 2024
Merged

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Mar 22, 2024

With the newest version of rules_go, @go_googleapis is not included anymore.
This includes the use of the same version of gazelle an googleapis as rules_go.
It also use golang dependencies as they are use in go.mod weren't used by gazelle.

This is follows envoyproxy/envoy#33063

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35
Copy link
Contributor Author

mmorel-35 commented Mar 22, 2024

@adisuissa , WDYT ?

I tried this patch here : envoyproxy/envoy#33084

Copy link

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM.
I just want to make sure the changes are propagating all the way down to go-control-plane and Istio, as AFAIK they are they depend on go. The go-control-plane repo is continuously using the latest Envoy build, so if the previous PR(s) landed and works, then I think it should be ok.
@howardjohn for Istio considerations (or forwarding to someone who may be the point of contact).

@mmorel-35
Copy link
Contributor Author

mmorel-35 commented Mar 25, 2024

The go-control-plane worked well with the last version, see : envoyproxy/go-control-plane@db0b36a

Concerning istio, I don't know where to look

@phlax
Copy link
Member

phlax commented Mar 27, 2024

istio repo is here https://github.com/istio/istio - searching on cncf/xds i reckon it shows where the dependencies are set https://github.com/search?q=repo%3Aistio%2Fistio%20cncf%2Fxds&type=code

might be worth trying an update there

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35
Copy link
Contributor Author

Anytging to add to merge this as the update og go-control-plane and xds in istio is passing ?

Copy link

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mmorel-35. IIUC istio/istio#50562 implies that it works for everything.
LGTM, thanks!

@adisuissa adisuissa merged commit 7e7c9ea into cncf:main Apr 19, 2024
4 checks passed
@mmorel-35 mmorel-35 deleted the rules_go/v0.46.0 branch April 19, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants