Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove dagmc dependency from partisn.py #17

Closed
gonuke opened this issue Jan 7, 2019 · 1 comment
Closed

remove dagmc dependency from partisn.py #17

gonuke opened this issue Jan 7, 2019 · 1 comment
Assignees
@kkiesling

Comments

@gonuke
Copy link
Member

gonuke commented Jan 7, 2019

The partisn routines only use dagmc to call discretize_geom. Instead of passing a DAGMC geometry, it could be possible to pass the data array that is the outcome of discretize_geom.

This will both localize the dagmc dependency and open the door for alternative ways of generating this data, and perhaps also different ways of testing partisn
@gonuke gonuke mentioned this issue Jan 7, 2019
Closed
@kkiesling kkiesling mentioned this issue Jan 8, 2019
Merged
@gonuke
Copy link
Member Author

gonuke commented Jan 9, 2019

Fixed by #28

@gonuke gonuke closed this as completed Jan 9, 2019
@gonuke gonuke mentioned this issue Jan 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kkiesling kkiesling

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gonuke @kkiesling