Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unicode_bidi aletter always true #440

Closed
ghglavan opened this issue May 22, 2019 · 1 comment
Closed

unicode_bidi aletter always true #440

ghglavan opened this issue May 22, 2019 · 1 comment

Comments

@ghglavan
Copy link

		if (('A' <= ch && ch <= 'Z') || ('a' <= ch && ch <= 'z') || (0x00AA == ch || 0x00B5 == ch || 0x00BA == ch) || (0x00C0 <= ch && ch <= 0x00D6) ||
			(0x00D8 <= ch && ch <= 0x00F6) || (0x00F8 <= ch && ch <= 0x0236) || (0x0250 <= ch || ch <= 0x02C1))
return unicode_character_type::aletter;

from here https://github.com/cnjinhao/nana/blob/master/source/unicode_bidi.cpp#L979.

shouldn't it be (0x0250 <= ch && ch <= 0x02C1) instead of (0x0250 <= ch || ch <= 0x02C1)?

@cnjinhao
Copy link
Owner

Thank you for pointing out this bug!

ghglavan pushed a commit to ghglavan/nana that referenced this issue May 23, 2019
Xeverous pushed a commit to Xeverous/nana that referenced this issue Jul 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants