Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support facebooks OpenR routing plattform #18

Merged
merged 5 commits into from
Apr 16, 2019
Merged

Support facebooks OpenR routing plattform #18

merged 5 commits into from
Apr 16, 2019

Conversation

butjar
Copy link
Contributor

@butjar butjar commented Apr 10, 2019

The PR adds support for facebooks open source routing platform OpenR. It's traditional link state routing protocol with a modular architecture.

Since the build script for OpenR is currently broken the OpenR daemon can be built as described in facebook/openr#41.

oliviertilmans
oliviertilmans reviewed Apr 11, 2019
View reviewed changes
Copy link
Member

@oliviertilmans oliviertilmans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, assuming that you have tested it (I cannot do so at the moment).

ipmininet/router/__router.py Outdated Show resolved Hide resolved
ipmininet/router/config/openrd.py Outdated Show resolved Hide resolved
ipmininet/router/config/openrd.py Show resolved Hide resolved
@oliviertilmans
Copy link
Member

Thanks!
As mentionned in #21, I think we need to integrate the OpenR build script somewhere to enable people to actually use it "easily" (as that is anyway the goal of this framework...).
Again, I am fine with merging this PR, but would like to use it as an opportunity to think about a wider setup script.

@butjar
[OpenR] Add basic configuration to support OpenR
f298471 
https://code.fb.com/connectivity/introducing-open-r-a-new-modular-routing-platform/

This commits contains all changes required to run an OpenR router in
ipmininet. The openr openrd config files have been copied from the ospf
daemons and work analogously.
@butjar
[OpenR] Add network example and docu
eb0f5d0 
Add a small OpenR network topology and document it in an appropriate
section in the README.
@butjar
[OpenR] Add basic configuration to support OpenR
f856c5e 
https://code.fb.com/connectivity/introducing-open-r-a-new-modular-routing-platform/

This commits contains all changes required to run an OpenR router in
ipmininet. The openr openrd config files have been copied from the ospf
daemons and work analogously.
@butjar
[OpenR] Add network example and docu
9a21442 
Add a small OpenR network topology and document it in an appropriate
section in the README.
@butjar butjar force-pushed the Support-facebooks-openr-routing-plattform branch from ddf7e1e to 9a21442 Compare April 11, 2019 15:45
@butjar
[OpenR] Document daemon parameters
4752c82 
cnp3#18 (comment)

Document the parameters and default values passed to the OpenR daemon
with pydoc.
@jadinm jadinm mentioned this pull request Apr 15, 2019
Merged
@oliviertilmans
Copy link
Member

Thanks for this!
We'll eventually work on the dry_run if that ever creates an issue in the future.

@oliviertilmans oliviertilmans merged commit 006e4e7 into cnp3:master Apr 16, 2019
@butjar butjar mentioned this pull request Apr 16, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertilmans oliviertilmans oliviertilmans left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@butjar @oliviertilmans