Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the issue where the license may be an object #587

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

Beace
Copy link
Contributor

@Beace Beace commented Sep 5, 2023

有些 package 的 license 是个对象,会导致 es 写入失败 #585 (comment)

image

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #587 (79a98e5) into master (89f6b98) will decrease coverage by 0.06%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #587      +/-   ##
==========================================
- Coverage   96.99%   96.94%   -0.06%     
==========================================
  Files         180      180              
  Lines       17360    17365       +5     
  Branches     2255     2251       -4     
==========================================
- Hits        16838    16834       -4     
- Misses        522      531       +9     
Files Changed Coverage Δ
app/core/service/PackageSearchService.ts 93.83% <100.00%> (ø)
app/repository/PackageRepository.ts 98.22% <100.00%> (+0.01%) ⬆️

... and 2 files with indirect coverage changes

Copy link
Member

@fengmk2 fengmk2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@fengmk2 fengmk2 added the bug Something isn't working label Sep 5, 2023
@fengmk2 fengmk2 merged commit 88b6afb into cnpm:master Sep 5, 2023
7 of 8 checks passed
fengmk2 pushed a commit that referenced this pull request Sep 5, 2023
[skip ci]

## [3.43.5](v3.43.4...v3.43.5) (2023-09-05)

### Bug Fixes

* the license may be an object ([#587](#587)) ([88b6afb](88b6afb)), closes [/github.com//issues/585#issuecomment-1706009496](https://github.com/cnpm//github.com/cnpm/cnpmcore/issues/585/issues/issuecomment-1706009496)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants