Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support npm update feat #133

Merged
merged 3 commits into from
Oct 12, 2016
Merged

feat: support npm update feat #133

merged 3 commits into from
Oct 12, 2016

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Sep 27, 2016

just rm node_module and run npminstall again

closes #132


This change is Reviewable

@fengmk2 fengmk2 added this to the 2.x milestone Sep 27, 2016
@mention-bot
Copy link

@fengmk2, thanks for your PR! By analyzing the annotation information on this pull request, we identified @dead-horse to be a potential reviewer

@@ -3,6 +3,8 @@
git clone https://github.com/ant-design/ant-design.git
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@afc163 ant-desgin 的 install 简直可以作为 npm install 的基准测试。。。

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

项目大,比较复杂。你还可以试试 https://github.com/ant-design/ant-design-mobile/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mobile 快多了。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

主要是 babel + webpack 太恶心

@afc163
Copy link
Contributor

afc163 commented Sep 27, 2016

你们这里接了好多奇怪的服务...

@codecov-io
Copy link

codecov-io commented Sep 27, 2016

Current coverage is 91.65% (diff: 100%)

Merging #133 into master will decrease coverage by 0.29%

@@             master       #133   diff @@
==========================================
  Files            18         18          
  Lines          1019       1019          
  Methods          63         63          
  Messages          0          0          
  Branches        196        196          
==========================================
- Hits            937        934     -3   
- Misses           82         85     +3   
  Partials          0          0          

Powered by Codecov. Last update b9a8fb3...40a8075

@fengmk2
Copy link
Member Author

fengmk2 commented Sep 27, 2016

@afc163 主要是安全扫描。

cwd: root,
stdio: 'pipe',
}).end(() => {
assert(!fs.existsSync(path.join(path.join(root, 'node_modules/koa'))));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为什么这些文件都不存在了?不是应该重新安装好了么?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修复了

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

单测挂的?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

单测过了。

@fengmk2 fengmk2 force-pushed the npm-update branch 3 times, most recently from 51ba5bb to 5295e4b Compare October 6, 2016 15:44
@afc163
Copy link
Contributor

afc163 commented Oct 6, 2016

npm update 和 rm && install 还有一点不同,会列出更新的模块及版本号,最好把能这个补上。

@fengmk2 fengmk2 force-pushed the npm-update branch 2 times, most recently from befcfd1 to f0f55ee Compare October 11, 2016 18:14
@dead-horse
Copy link
Member

2.6.0

@dead-horse dead-horse deleted the npm-update branch October 12, 2016 03:21
@wssgcg1213
Copy link
Contributor

太简单粗暴了吧,实现一个 outdated + update 也不麻烦

@fengmk2
Copy link
Member Author

fengmk2 commented Nov 23, 2016

outdated 模块已经好多,请自行选择,安利 autod。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tnpm update 无效
6 participants