-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support npm update feat #133
Conversation
@fengmk2, thanks for your PR! By analyzing the annotation information on this pull request, we identified @dead-horse to be a potential reviewer |
@@ -3,6 +3,8 @@ | |||
git clone https://github.com/ant-design/ant-design.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@afc163 ant-desgin 的 install 简直可以作为 npm install 的基准测试。。。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
项目大,比较复杂。你还可以试试 https://github.com/ant-design/ant-design-mobile/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mobile 快多了。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
主要是 babel + webpack 太恶心
你们这里接了好多奇怪的服务... |
Current coverage is 91.65% (diff: 100%)@@ master #133 diff @@
==========================================
Files 18 18
Lines 1019 1019
Methods 63 63
Messages 0 0
Branches 196 196
==========================================
- Hits 937 934 -3
- Misses 82 85 +3
Partials 0 0
|
@afc163 主要是安全扫描。 |
cwd: root, | ||
stdio: 'pipe', | ||
}).end(() => { | ||
assert(!fs.existsSync(path.join(path.join(root, 'node_modules/koa')))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
为什么这些文件都不存在了?不是应该重新安装好了么?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
修复了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
单测过了。
51ba5bb
to
5295e4b
Compare
npm update 和 rm && install 还有一点不同,会列出更新的模块及版本号,最好把能这个补上。 |
befcfd1
to
f0f55ee
Compare
just rm node_module and run npminstall again closes #132
2.6.0 |
太简单粗暴了吧,实现一个 outdated + update 也不麻烦 |
outdated 模块已经好多,请自行选择,安利 autod。 |
just rm node_module and run npminstall again
closes #132
This change is