fix: should limit sub package install parallel #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fengmk2, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dead-horse, @welladamm and @popomore to be potential reviewers. |
fengmk2
force-pushed
the
fix-limit-sub-pkg-install-parallel
branch
from
907442a
to
8dd2c76
Compare
Codecov Report@@ Coverage Diff @@
## master #191 +/- ##
==========================================
+ Coverage 85.67% 85.69% +0.01%
==========================================
Files 19 19
Lines 1201 1202 +1
Branches 233 233
==========================================
+ Hits 1029 1030 +1
Misses 172 172
Continue to review full report at Codecov.
|
fengmk2
force-pushed
the
fix-limit-sub-pkg-install-parallel
branch
from
bb82d07
to
1941eaa
Compare
fengmk2
force-pushed
the
fix-limit-sub-pkg-install-parallel
branch
from
1941eaa
to
412bd99
Compare
dead-horse
reviewed
Feb 3, 2017
| @@ -205,7 +206,7 @@ function* _install(parentDir, pkg, ancestors, options) { | |||
| } | |||
| tasks.push(install(realPkgDir, childPkg, ancestors.concat(`${realPkg.name}@${realPkg.version}`), options)); | |||
| } | |||
| yield tasks; | |||
| yield parallel(tasks, 10); | |||
There was a problem hiding this comment.
感觉以后需要一个队列形式的模块来统一控制所有的并发。
options.taskHandler.push(tasks);There was a problem hiding this comment.
这样不太行，有可能导致 sub_install 和 install 之间相互依赖等待没法进行下去
|
local_install 已经控制了 10个 并发 install，而 install 里面又控制了 10个 sub_install 的并发，所以目前最大并发数是 100。 没改之前话，sub_install 的并发有可能超过几千。 |
|
2.19.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is