Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复 tag 支持 prerelease #3

Merged
merged 1 commit into from
Oct 13, 2020
Merged

Conversation

chenpx976
Copy link
Contributor

No description provided.

@chenpx976 chenpx976 force-pushed the fix/prerelease branch 4 times, most recently from 6909acb to aaae690 Compare October 12, 2020 10:07
@codecov
Copy link

codecov bot commented Oct 12, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@bd0d221). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             master        #3   +/-   ##
==========================================
  Coverage          ?   100.00%           
==========================================
  Files             ?         1           
  Lines             ?        14           
  Branches          ?         0           
==========================================
  Hits              ?        14           
  Misses            ?         0           
  Partials          ?         0           
Impacted Files Coverage Δ
index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd0d221...a02d6c1. Read the comment docs.

package.json Outdated
@@ -40,7 +40,7 @@
],
"ci": {
"type": "travis, azure-pipelines",
"version": "6, 8, 10",
"version": "8, 10, 12",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6还不能去掉,否则得发 major 版本了。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

});
});
it('beta', () => {
return safePublishTag('egg', '2.28.1-beta.0')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

加一个非预期的错误 version 格式用例?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

加了一个限制 prerelease tag 是 alpha beta rc

Copy link
Member

@fengmk2 fengmk2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

其他没问题了

@chenpx976 chenpx976 force-pushed the fix/prerelease branch 2 times, most recently from 4a52a31 to 9a9e4d9 Compare October 13, 2020 01:57
@fengmk2
Copy link
Member

fengmk2 commented Oct 13, 2020

看来是 ci 工具已经放弃了 node 6 的支持

@fengmk2 fengmk2 merged commit 74a4c7d into cnpm:master Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants