[#39] Build with GHC 8.2.2 and GHC 8.6.1 on CI #52
Conversation
There was a problem hiding this comment.
Hey @brandonhamilton! Thanks a lot for your contribution!
CI is still on but I can tell that as we are supporting GHC starting from 8.2.2 and up to 8.4.3 now we should change the base lower bound accordingly – base >= 4.10 && < 4.13. So this version will not break in the future.
chshersh
changed the title
co-log-core/co-log-core.cabal
Outdated
| @@ -28,7 +28,7 @@ library | |||
| Colog.Core.Class | |||
| Colog.Core.Severity | |||
|
|
|||
| build-depends: base >= 4.11 && < 5 | |||
| build-depends: base >= 4.10 && < 5 | |||
There was a problem hiding this comment.
The point to make it < 4.13 is that when the new base version will be released we still can guarantee that this version of our library will work as expected. If we specify < 5 this would mean that the breaking changes of base-4.13.* or later can break this particular version of our library and we will need to make a revision on Hackage to tighten the base bounds to < 4.13. I hope this explanation makes sense.
There was a problem hiding this comment.
Yes, that makes sense 👍
|
Aha - there is now a build issue on 8.2.2 |
|
Yes thanks; you've done all the work in figuring out the cause 😉 |
|
@brandonhamilton Sorry, turned out I was wrong (so I've deleted my comment). The old interface was only in the GHC 8.0.2 and the new one appeared in GHC 8.2.2. So this is not actually a reason of error... |
|
@brandonhamilton Okay, looks like GHC 8.2.2 has total disrespect to fromLabel field = TM.WrapTypeable $ MessageField @_ @fieldName fieldSo I think you still can use |
Closes #39