Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#39] Build with GHC 8.2.2 and GHC 8.6.1 on CI #52

Merged
merged 4 commits into from Oct 4, 2018
Merged

[#39] Build with GHC 8.2.2 and GHC 8.6.1 on CI #52

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f7a44bf
Build with GHC 8.2.2 and GHC 8.6.1 on CI
brandonhamilton Oct 4, 2018
4e21d22
Fix lower bounds on base
brandonhamilton Oct 4, 2018
bd0b50c
Pin upper bound on base
brandonhamilton Oct 4, 2018
7735ebf
Fix compilation with GHC 8.2
brandonhamilton Oct 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion co-log-core/co-log-core.cabal
View file
Open in desktop
Expand Up @@ -28,7 +28,7 @@ library
Colog.Core.Class
Colog.Core.Severity

build-depends: base >= 4.11 && < 5
build-depends: base >= 4.10 && < 5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The point to make it < 4.13 is that when the new base version will be released we still can guarantee that this version of our library will work as expected. If we specify < 5 this would mean that the breaking changes of base-4.13.* or later can break this particular version of our library and we will need to make a revision on Hackage to tighten the base bounds to < 4.13. I hope this explanation makes sense.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that makes sense 👍


ghc-options: -Wall
-Wincomplete-uni-patterns
Expand Down
2 changes: 1 addition & 1 deletion co-log/co-log.cabal
View file
Open in desktop
Expand Up @@ -33,7 +33,7 @@ library
Colog.Pure
other-modules: Prelude

build-depends: base-noprelude >= 4.11 && < 5
build-depends: base-noprelude >= 4.10 && < 5
, ansi-terminal ^>= 0.8
, bytestring ^>= 0.10.8
, co-log-core ^>= 0.1.0
Expand Down