Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InvalidLinkBear: change complex regex to use re.VERBOSE mode #1018

Closed
coala-bot opened this issue Nov 19, 2016 · 4 comments
Closed

InvalidLinkBear: change complex regex to use re.VERBOSE mode #1018

coala-bot opened this issue Nov 19, 2016 · 4 comments
Assignees
@madhur-tandon

Comments

@coala-bot
Copy link

Opened via gitter by @jayvdb
@jayvdb
Copy link
Member

jayvdb commented Nov 19, 2016

f32dc3dd701c7e57b3 includes lots of lovely documentation of the quite complex regex, so it is easier to hack. This should be done as a separate task. which doesnt introduce functional changes.

Then it is easier to review a patch which has functional changes.

@jayvdb jayvdb mentioned this issue Nov 19, 2016
Closed
@madhur-tandon
Copy link
Member

madhur-tandon commented Nov 19, 2016 •
edited
Loading

@jayvdb In this PR, I should just let the regex use re.VERBOSE mode (without documentation) right ? and then put the documentation through my old PR #932 ?
Also, the complex regex we are talking about refers to which one ? The one implemented currently OR The one I am trying to implement (for fixing #758 in #932) ?

@jayvdb
Copy link
Member

jayvdb commented Nov 19, 2016

No. The current regex is complex, and should be documented using re.X mode.

@Makman2
Copy link
Member

Makman2 commented Nov 19, 2016 •
edited
Loading

Let's just append comments like this instead of using re.X:

re.compile("abc" # matches abc
           "def") # super complex def match

madhur-tandon added a commit to madhur-tandon/coala-bears that referenced this issue Nov 19, 2016
@madhur-tandon
InvalidLinkBear.py: Document regex in Verbose
803a6a1 
Document complex regex using ``re.X`` mode

Closes coala#1018
@madhur-tandon madhur-tandon mentioned this issue Nov 19, 2016
Merged
madhur-tandon added a commit to madhur-tandon/coala-bears that referenced this issue Nov 20, 2016
@madhur-tandon
InvalidLinkBear.py: Document regex
ff04f87 
Document complex regex using ``re.X`` mode

Closes coala#1018
madhur-tandon added a commit to madhur-tandon/coala-bears that referenced this issue Nov 20, 2016
@madhur-tandon
InvalidLinkBear.py: Document regex
b5ac486 
Document complex regex using ``re.X`` mode

Closes coala#1018
madhur-tandon added a commit to madhur-tandon/coala-bears that referenced this issue Nov 21, 2016
@madhur-tandon
InvalidLinkBear.py: Document regex
765a48f 
Document complex regex using ``re.X`` mode

Closes coala#1018
madhur-tandon added a commit to madhur-tandon/coala-bears that referenced this issue Nov 25, 2016
@madhur-tandon
InvalidLinkBear.py: Document regex
7b55069 
Document complex regex using ``re.X`` mode

Closes coala#1018
madhur-tandon added a commit to madhur-tandon/coala-bears that referenced this issue Nov 25, 2016
@madhur-tandon
InvalidLinkBear.py: Document regex
8c4fc09 
Document complex regex using ``re.X`` mode

Closes coala#1018
madhur-tandon added a commit to madhur-tandon/coala-bears that referenced this issue Nov 25, 2016
@madhur-tandon
InvalidLinkBear.py: Document regex
0a613bd 
Document complex regex using ``re.X`` mode

Closes coala#1018
madhur-tandon added a commit to madhur-tandon/coala-bears that referenced this issue Nov 26, 2016
@madhur-tandon
InvalidLinkBear.py: Document regex
baffab0 
Document complex regex using ``re.X`` mode

Closes coala#1018
madhur-tandon added a commit to madhur-tandon/coala-bears that referenced this issue Nov 27, 2016
@madhur-tandon
InvalidLinkBear.py: Document regex
95a1679 
Document complex regex using ``re.X`` mode

Closes coala#1018
madhur-tandon added a commit to madhur-tandon/coala-bears that referenced this issue Nov 27, 2016
@madhur-tandon
InvalidLinkBear.py: Document regex
67c5dad 
Document complex regex using ``re.X`` mode

Closes coala#1018
madhur-tandon added a commit to madhur-tandon/coala-bears that referenced this issue Nov 28, 2016
@madhur-tandon
InvalidLinkBear.py: Document regex
bb0caad 
Document complex regex using ``re.VERBOSE`` mode

Closes coala#1018
madhur-tandon added a commit to madhur-tandon/coala-bears that referenced this issue Nov 28, 2016
@madhur-tandon
InvalidLinkBear.py: Document regex
cdb153c 
Document complex regex using ``re.VERBOSE`` mode

Closes coala#1018
@madhur-tandon madhur-tandon mentioned this issue Nov 28, 2016
Closed
gosom pushed a commit to gosom/coala-bears that referenced this issue Jul 15, 2017
@madhur-tandon
InvalidLinkBear.py: Document regex
d8550f6 
Document complex regex using ``re.VERBOSE`` mode

Closes coala#1018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@madhur-tandon madhur-tandon

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jayvdb @Makman2 @madhur-tandon @coala-bot