Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP8NotebookBear: requirement nbformat>=4.1 #1212

Closed
jayvdb opened this issue Dec 26, 2016 · 0 comments
Closed

PEP8NotebookBear: requirement nbformat>=4.1 #1212

jayvdb opened this issue Dec 26, 2016 · 0 comments
Assignees
@sils
Labels
status/needs info

Comments

@jayvdb
Copy link
Member

jayvdb commented Dec 26, 2016

#1042 (specifically 7b48519) changed the requirement from nbformat>=4.* to nbformat>=4.1, with the same change occurring with the PipRequirement in PEP8NotebookBear.py.

note https://pypi.python.org/pypi/nbformat v4.2 has been released since then.

This is the only >= syntax in requirements.txt. It doesnt not seem to have been spotted/discussed in the PR. Is it necessary; can we switch to using nbformat~=4.1
This was referenced Dec 26, 2016
Open
Merged
jayvdb added a commit to jayvdb/coala-bears that referenced this issue Dec 31, 2016
@jayvdb
PEP8NotebookBear: Require nbformat~=4.1
16e5f16 
Use nbformat~=4.1 instead of nbformat>=4.1
to be consistent with other entries in requirements.txt

Closes coala#1212
@rultor rultor closed this as completed in 2b52dfe Jan 1, 2017
gosom pushed a commit to gosom/coala-bears that referenced this issue Jul 15, 2017
@jayvdb
PEP8NotebookBear: Require nbformat~=4.1
00743e1 
Use nbformat~=4.1 instead of nbformat>=4.1
to be consistent with other entries in requirements.txt

Closes coala#1212
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sils sils

Labels
status/needs info
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jayvdb @sils