Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KeywordBear: Explain how language setting is used #2798

Open
jayvdb opened this issue Nov 29, 2018 · 2 comments
Open

KeywordBear: Explain how language setting is used #2798

jayvdb opened this issue Nov 29, 2018 · 2 comments
Assignees
@IronPenguin4179
Labels
area/documentation area/genericbears difficulty/newcomer

Comments

@jayvdb
Copy link
Member

jayvdb commented Nov 29, 2018

The language setting is only used to generate the diff correctly. It is not used to influence where the keyword may appear.
@nishantsharma09
Copy link

Hi! Can I be assigned to this issue?

@IronPenguin4179
Copy link

I've looked over the KeywordBear file and can tell generally what all the functions are doing, but I don't know what you mean by language setting. This is my first issue and I'm still unclear on how things work overall. Can you give me any clarification?

IronPenguin4179 added a commit to IronPenguin4179/coala-bears that referenced this issue Mar 19, 2019
@IronPenguin4179
KeywordBearTest.py: Adds clarifying comment
a9cc0ce 
Added comment to clarify that language setting is only used for
generating diff.

Fixes coala#2798
IronPenguin4179 added a commit to IronPenguin4179/coala-bears that referenced this issue Mar 19, 2019
@IronPenguin4179
KeywordBearTest.py: Add language comment
a009f31 
Adds comment clarifying use of language setting.

Fixes coala#2798
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IronPenguin4179 IronPenguin4179

Labels
area/documentation area/genericbears difficulty/newcomer
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jayvdb @IronPenguin4179 @nishantsharma09