Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen pins based on openSUSE build 20190215 #2877

Open
jayvdb opened this issue Feb 14, 2019 · 17 comments · May be fixed by #2890
Open

Loosen pins based on openSUSE build 20190215 #2877

jayvdb opened this issue Feb 14, 2019 · 17 comments · May be fixed by #2890

Comments

@jayvdb
Copy link
Member

jayvdb commented Feb 14, 2019

opensuse_tumbleweed_build_green_20190215.txt

Attached is a build log of https://build.opensuse.org/package/show/home:jayvdb:coala/python-coala-bears , while green.

Identify the linter versions used, where the bear tests pass, and update the bear requirements to allow these versions.

The tests should not need to be updated, as the tests are currently passing on opensuse build machines using those versions.

Where the tests need to be updated, maybe due to some difference between openSUSE and Ubuntu, they should be modified so that the old versions of the linter still would pass the tests.

Add notes here if there are any which are needing discussion, especially if the tests fail extensively.

@jayvdb
Copy link
Member Author

jayvdb commented Feb 14, 2019

Ignore pylint, which is covered by #2826 , and also look for any other issues/PRs which are doing version bumps.

@KVGarg
Copy link
Contributor

KVGarg commented Mar 10, 2019

@jayvdb bear-requirements.txt contains all linter packages, right ? There is no such package name that is not a linter or a validator

@jayvdb
Copy link
Member Author

jayvdb commented Mar 11, 2019

bear-requirements.txt contains all python dependencies, and they all need to be using openSUSE compatible versions.

e.g. aenum is not a validator or linter, but is a dependency.

@KVGarg
Copy link
Contributor

KVGarg commented Mar 12, 2019

Upgrading the version of radon to 3.4.1 is raising an error pyprint 0.2.6 has requirement colorama~=0.3.7, but you'll have colorama 0.4.1 which is incompatible. So, keeping it to its earlier version.

@abhishalya
Copy link
Member

@KVGarg You don't have to upgrade the bears-requirements, we have to allow the requirements for the versions given here so that the build passes.

@KVGarg
Copy link
Contributor

KVGarg commented Mar 12, 2019

@abhishalya Correct me if I am wrong!

Identify the linter versions used, where the bear tests pass, and update the bear requirements to allow these versions

Say, ApertiumLintBearTest test is passed, then the corresponding bear(i.e ApertiumLintBear) class has a variable Requirements which needs to update requirements to allow these versions!
Also, If I'm going correct then these linter versions also needs to be updated in bear-requirements.txt

Sorry, If I'm going in wrong direction ;-)

@abhishalya
Copy link
Member

@KVGarg Yep, and by update I mean modify or change (and not upgrade).

@KVGarg
Copy link
Contributor

KVGarg commented Mar 14, 2019

@jayvdb Would like to take up this issue! Can you assign it to me ?

@KVGarg
Copy link
Contributor

KVGarg commented Mar 15, 2019

@jayvdb Changing version of radon from 1.4.0 to 3.0.1 was creating a colorama package conflict as it installs colorma 0.4.1 but requirement of package pyPrint is colorama<0.4
Also, YapfBearTest has been failing. I guess it is due to change in version.

Can you help me!! Created a PR for it already

@bkhanale
Copy link
Member

@KVGarg Since the file provided in the issue statement passes the build, you can update the requirements as per the file. Has there been any recent change in the upstream repos? Since the build is quite new 20190215.

@KVGarg
Copy link
Contributor

KVGarg commented Mar 15, 2019

I have updated the requirements as per file, only then the bild is failing due to radon and yapf

@bkhanale
Copy link
Member

Ah, this bumps up the colorama version in radon, it was a recent change. You can downgrade the version of radon in that case. Do this for all occurring conflicts, finally the build should be green.

@KVGarg
Copy link
Contributor

KVGarg commented Mar 15, 2019

Thnx @bkhanale I will downgrade the version of radon as well as for yapf

KVGarg added a commit to KVGarg/coala-bears that referenced this issue Mar 15, 2019
The commit updates the bear requirements to allow
new linter versions used. The new linter versions are
identified from an openSUSE [build log](https://github.com/coala/coala-bears/files/2866861/opensuse_tumbleweed_build_green_20190215.txt) where the
bears' test pass.

Closes coala#2877
KVGarg added a commit to KVGarg/coala-bears that referenced this issue Mar 15, 2019
The commit updates the bear requirements to allow
new linter versions used. The new linter versions are
identified from an openSUSE build log where the
bears' test pass.

Closes coala#2877
KVGarg added a commit to KVGarg/coala-bears that referenced this issue Mar 15, 2019
The commit updates the bear requirements to allow
new linter versions used. The new linter versions are
identified from an openSUSE build log where the
bears' test pass.

Closes coala#2877
@KVGarg
Copy link
Contributor

KVGarg commented Mar 15, 2019

Due to package jsonschema requirements version of six should be greater or equal to 1..11.0
And currently, coala uses version 1.10.0. There is a need of change of version of six in-order to get travis ci pass for Python3.4. What should we do now?
Attached build log installs version 1.12.0 of six

@abhishalya
Copy link
Member

Let me fix that myself, then you could cherry pick my commit in your PR.

@KVGarg
Copy link
Contributor

KVGarg commented Mar 15, 2019

Let me fix that myself,

OK
jsonschema has dropped the support for Python3.4 python-jsonschema/jsonschema@2387d08
Due to which i Guess its making travis ci red

@abhishalya
Copy link
Member

Reference issue #2885

KVGarg added a commit to KVGarg/coala-bears that referenced this issue Jul 22, 2019
The commit updates the bear requirements to allow
new linter versions used. The new linter versions are
identified from an openSUSE build log where the
bears' test pass.

Closes coala#2877
KVGarg added a commit to KVGarg/coala-bears that referenced this issue Jul 22, 2019
The commit updates the bear requirements to allow
new linter versions used. The new linter versions are
identified from an openSUSE build log where the
bears' test pass.

Closes coala#2877
KVGarg added a commit to KVGarg/coala-bears that referenced this issue Jul 22, 2019
The commit updates the bear requirements to allow
new linter versions used. The new linter versions are
identified from an openSUSE build log where the
bears' test pass.

Closes coala#2877
KVGarg added a commit to KVGarg/coala-bears that referenced this issue Jul 22, 2019
The commit updates the bear requirements to allow
new linter versions used. The new linter versions are
identified from an openSUSE build log where the
bears' test pass.

Closes coala#2877
KVGarg added a commit to KVGarg/coala-bears that referenced this issue Jul 22, 2019
The commit updates the bear requirements to allow
new linter versions used. The new linter versions are
identified from an openSUSE build log where the
bears' test pass.

Closes coala#2877
KVGarg added a commit to KVGarg/coala-bears that referenced this issue Jul 24, 2019
The commit updates the bear requirements to allow
new linter versions used. The new linter versions are
identified from an openSUSE build log where the
bears' test pass.

Closes coala#2877
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

4 participants